[Lldb-commits] [lldb] r206751 - Revert "Fix TestPtrRef2Typedef with new const adornment on expected ref type."

[Todd Fiala]

Thanks, Ed!

Yeah I was going to eventually drill into this.  Not sure what changed it -
unfortunately this showed up during a period where Linux builds were not
working, so it's not clear what broke it.


On Mon, Apr 21, 2014 at 7:10 AM, Ed Maste <emaste at freebsd.org> wrote:

> Author: emaste
> Date: Mon Apr 21 09:10:38 2014
> New Revision: 206751
>
> URL: http://llvm.org/viewvc/llvm-project?rev=206751&view=rev
> Log:
> Revert "Fix TestPtrRef2Typedef with new const adornment on expected ref
> type."
>
> The additional "const" breaks the FreeBSD buildbot, and does not appear
> to be due to a LLVM or Clang change.  Revert the change while
> investigating further.
>
> This reverts revision 206619.
>
> Modified:
>
> lldb/trunk/test/functionalities/data-formatter/ptr_ref_typedef/TestPtrRef2Typedef.py
>
> Modified:
> lldb/trunk/test/functionalities/data-formatter/ptr_ref_typedef/TestPtrRef2Typedef.py
> URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/data-formatter/ptr_ref_typedef/TestPtrRef2Typedef.py?rev=206751&r1=206750&r2=206751&view=diff
>
> ==============================================================================
> ---
> lldb/trunk/test/functionalities/data-formatter/ptr_ref_typedef/TestPtrRef2Typedef.py
> (original)
> +++
> lldb/trunk/test/functionalities/data-formatter/ptr_ref_typedef/TestPtrRef2Typedef.py
> Mon Apr 21 09:10:38 2014
> @@ -58,8 +58,8 @@ class PtrRef2TypedefTestCase(TestBase):
>          self.runCmd('type summary add --cascade true -s "IntRRef" "int
> &&"')
>
>          self.expect("frame variable x", substrs = ['(Foo *) x =
> 0x','IntPointer'])
> -        self.expect("frame variable y", substrs = ['(Foo &const) y =
> 0x','IntLRef'])
> -        self.expect("frame variable z", substrs = ['(Foo &&const) z =
> 0x','IntRRef'])
> +        self.expect("frame variable y", substrs = ['(Foo &) y =
> 0x','IntLRef'])
> +        self.expect("frame variable z", substrs = ['(Foo &&) z =
> 0x','IntRRef'])
>
>  if __name__ == '__main__':
>      import atexit
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>



-- 
Todd Fiala | Software Engineer | tfiala at google.com | 650-943-3180
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140421/11f1a68e/attachment.html>