[Lldb-commits] [lldb] r204725 - Update 'running threaded' messages after option parsing change

Ed Maste emaste at freebsd.org
Tue Mar 25 08:17:24 PDT 2014


Author: emaste
Date: Tue Mar 25 10:17:23 2014
New Revision: 204725

URL: http://llvm.org/viewvc/llvm-project?rev=204725&view=rev
Log:
Update 'running threaded' messages after option parsing change

"Running multithreaded with n threads (from LLDB_TEST_THREADS)" is
incorrect in the common case, because the thread count is now obtained
from a --threads option, or a default of multiprocessing.cpu_count().

I left the messages in for now as there are some intermittent issues
that happen while running tests multithreaded and it may help in
triaging those.  We may wish to just remove them later on.

Modified:
    lldb/trunk/test/dosep.ty

Modified: lldb/trunk/test/dosep.ty
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/dosep.ty?rev=204725&r1=204724&r2=204725&view=diff
==============================================================================
--- lldb/trunk/test/dosep.ty (original)
+++ lldb/trunk/test/dosep.ty Tue Mar 25 10:17:23 2014
@@ -13,8 +13,6 @@ from optparse import OptionParser
 # Command template of the invocation of the test driver.
 template = '%s/dotest.py %s -p %s %s'
 
-multithreaded_envar = 'LLDB_TEST_THREADS'
-
 def process_dir(root, files, test_root, dotest_options):
     """Examine a directory for tests, and invoke any found within it."""
     failed = []
@@ -57,7 +55,7 @@ def walk_and_invoke(test_root, dotest_op
     failed = []
     passed = []
     if (num_threads > 1):
-        print "Running multithreaded with " + str(num_threads) + " threads (from " + multithreaded_envar + ")"
+        print("Running multithreaded with %d threads" % num_threads)
         global in_q
         global out_q
         in_q = Queue.Queue()
@@ -67,7 +65,7 @@ def walk_and_invoke(test_root, dotest_op
             t.daemon = True
             t.start()
     else:
-        print "NOT running multithreaded.  Consider setting " + multithreaded_envar + " environment variable."
+        print("Running single-threaded")
     for root, dirs, files in os.walk(test_root, topdown=False):
         if (num_threads > 1):
             in_q.put((root, files, test_root, dotest_options))





More information about the lldb-commits mailing list