[Lldb-commits] [PATCH 4/4] Move internal header dependency to DNBArchImplX86_64.cpp

[Todd Fiala]

I submitted it but I need to amend the commit message - I forgot to
attribute it to you, Kuba.  Sorry, working on it.


On Thu, Mar 13, 2014 at 2:19 PM, Todd Fiala <tfiala at google.com> wrote:

> Yeah everything is fine now.  Built and tested fine on Linux as well.  I'm
> checking it in as a single commit in a minute here...
>
>
> On Thu, Mar 13, 2014 at 2:02 PM, Kuba Ober <kuba at mareimbrium.org> wrote:
>
>> It seems like it’s a bug in source/Interpreter/Makefile - it wrongly
>> generates
>> the file in the source directory, not in the build directory. cmake
>> handles
>> the same correctly.
>>
>> For now you should be able to nuke that file. When you run make on “plain”
>> (non-generated) makefiles, it will get regenerated, of course.
>>
>> Basically, you’ve run plain makefiles, and then run cmake on such an
>> adulterated
>> git checkout. It would have worked on untouched checkout.
>>
>> — Kuba
>>
>> On Mar 13, 2014, at 4:54 PM, Todd Fiala <tfiala at google.com> wrote:
>>
>> > I think that is the wrapper file generated by swig for python
>> interaction.  Should I be trying this with python disabled?  I can nuke
>> that file and try again.
>> >
>> >
>> > On Thu, Mar 13, 2014 at 1:47 PM, Kuba Ober <kuba at mareimbrium.org>
>> wrote:
>> > This is the culprit:
>> >
>> > CMake Error at cmake/modules/LLVMProcessSources.cmake:66 (message):
>> >   Found unknown source file
>> >   /Users/tfiala/lldb/svn/llvm/tools/lldb/source/LLDBWrapPython.cpp
>> >
>> >   Please update
>> /Users/tfiala/lldb/svn/llvm/tools/lldb/source/CMakeLists.txt
>> >
>> > I don’t know where this file came from, but it’s not supposed to be
>> there,
>> > and it’s not in the CMakeLists. Spurious source files make cmake abort.
>> > Maybe it was added after I pulled yesterday?
>> >
>> > Cheers, Kuba
>> >
>> > On Mar 13, 2014, at 4:23 PM, Todd Fiala <tfiala at google.com> wrote:
>> >
>> > > BTW - this also happens if I go with cmake using the default output
>> format and not Ninja:
>> > > cmake ../llvm
>> > >
>> > > I've attached the cmake output from that run.
>> > >
>> > >
>> > > On Thu, Mar 13, 2014 at 1:13 PM, Todd Fiala <tfiala at google.com>
>> wrote:
>> > > Hey Kuba,
>> > >
>> > > I applied all your patches (listed as #1 - 4) from this series to a
>> top of tree LLDB trunk branch (svn r203828).  I'm building on OS X 10.9.
>> > >
>> > > I'm using a directory structure like this:
>> > > |- llvm
>> > > |- build
>> > >
>> > > cd build
>> > > cmake -GNinja ../llvm
>> > >
>> > > cmake is failing with this message:
>> > >
>> > >
>> > > -- The ASM-ATT compiler identification is unknown
>> > > -- Found assembler: /usr/bin/as
>> > > -- Configuring incomplete, errors occurred!
>> > > See also "/Users/tfiala/lldb/svn/build/CMakeFiles/CMakeOutput.log".
>> > > See also "/Users/tfiala/lldb/svn/build/CMakeFiles/CMakeError.log".
>> > > tfiala-macbookpro:build tfiala$ svn info
>> > > svn: E155007: '/Users/tfiala/lldb/svn/build' is not a working copy
>> > > tfiala-macbookpro:build tfiala$
>> > >
>> > > Here's my OS version:
>> > > uname -a
>> > > Darwin tfiala-macbookpro.roam.corp.google.com 13.1.0 Darwin Kernel
>> Version 13.1.0: Thu Jan 16 19:40:37 PST 2014;
>> root:xnu-2422.90.20~2/RELEASE_X86_64 x86_64
>> > >
>> > > Any thoughts?
>> > >
>> >
>> >
>> >
>> >
>> > --
>> > Todd Fiala |   Software Engineer |     tfiala at google.com |
>> 650-943-3180
>> >
>>
>>
>
>
> --
> Todd Fiala | Software Engineer |  tfiala at google.com |  650-943-3180
>



-- 
Todd Fiala | Software Engineer | tfiala at google.com | 650-943-3180
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140313/fe3acc46/attachment.html>