[Lldb-commits] [lldb] r203384 - PlatformWindows: Fix ObjectFile presence test conditions (could result in NULL memory access)

Virgile Bello virgile.bello at gmail.com
Sun Mar 9 03:00:40 PDT 2014


Author: xen2
Date: Sun Mar  9 05:00:40 2014
New Revision: 203384

URL: http://llvm.org/viewvc/llvm-project?rev=203384&view=rev
Log:
PlatformWindows: Fix ObjectFile presence test conditions (could result in NULL memory access)

Modified:
    lldb/trunk/source/Plugins/Platform/Windows/PlatformWindows.cpp

Modified: lldb/trunk/source/Plugins/Platform/Windows/PlatformWindows.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/Windows/PlatformWindows.cpp?rev=203384&r1=203383&r2=203384&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Platform/Windows/PlatformWindows.cpp (original)
+++ lldb/trunk/source/Plugins/Platform/Windows/PlatformWindows.cpp Sun Mar  9 05:00:40 2014
@@ -224,7 +224,7 @@ PlatformWindows::ResolveExecutable (cons
                                                  NULL,
                                                  NULL);
 
-            if (!exe_module_sp && exe_module_sp->GetObjectFile() == NULL)
+            if (!exe_module_sp || exe_module_sp->GetObjectFile() == NULL)
             {
                 exe_module_sp.reset();
                 error.SetErrorStringWithFormat ("'%s' doesn't contain the architecture %s",





More information about the lldb-commits mailing list