[Lldb-commits] [lldb] r201614 - <rdar://problem/15960553>

[Todd Fiala]

FWIW I am seeing a similar set fail on top of tree Ubuntu 12.04 this
morning:

Ran 278 tests.
Failing Tests (8)
FAIL: LLDB (suite) :: TestWatchpointConditionAPI.py (Linux
tfiala2.mtv.corp.google.com 3.2.5-gg1336 #1 SMP Thu Aug 29 02:37:18 PDT
2013 x86_64 x86_64)
FAIL: LLDB (suite) :: TestTargetWatchAddress.py (Linux
tfiala2.mtv.corp.google.com 3.2.5-gg1336 #1 SMP Thu Aug 29 02:37:18 PDT
2013 x86_64 x86_64)
FAIL: LLDB (suite) :: TestWatchpointIter.py (Linux
tfiala2.mtv.corp.google.com 3.2.5-gg1336 #1 SMP Thu Aug 29 02:37:18 PDT
2013 x86_64 x86_64)
FAIL: LLDB (suite) :: TestWatchpointIgnoreCount.py (Linux
tfiala2.mtv.corp.google.com 3.2.5-gg1336 #1 SMP Thu Aug 29 02:37:18 PDT
2013 x86_64 x86_64)
FAIL: LLDB (suite) :: TestSetWatchpoint.py (Linux
tfiala2.mtv.corp.google.com 3.2.5-gg1336 #1 SMP Thu Aug 29 02:37:18 PDT
2013 x86_64 x86_64)
FAIL: LLDB (suite) :: TestProcessAPI.py (Linux
tfiala2.mtv.corp.google.com3.2.5-gg1336 #1 SMP Thu Aug 29 02:37:18 PDT
2013 x86_64 x86_64)
FAIL: LLDB (suite) :: TestStaticVariables.py (Linux
tfiala2.mtv.corp.google.com 3.2.5-gg1336 #1 SMP Thu Aug 29 02:37:18 PDT
2013 x86_64 x86_64)
FAIL: LLDB (suite) :: TestConvenienceVariables.py (Linux
tfiala2.mtv.corp.google.com 3.2.5-gg1336 #1 SMP Thu Aug 29 02:37:18 PDT
2013 x86_64 x86_64)
make: *** [check-local] Error 1
make: Leaving directory `/mnt/ssd/work/git/llgs/build/tools/lldb/test'

You can ignore the TestConvenienceVariables.py - that is one that fails due
to the python readline issue that I'm not working around in this test run.


On Wed, Feb 19, 2014 at 10:00 AM, Enrico Granata <egranata at apple.com> wrote:

> Let me investigate this.
>
> My gut feeling is we might not be fetching the file globals anymore. We
> might need to fetch them and append them to our local VariableList.
>
> The easy way to verify this would be to grab the frame's VariableList in
> the global case and AppendIfUnique it to the one we made from the block.
>
> I am not in the office now but can verify later or feel free to play with
> it yourself of course.
>
> Sent from the iPhone of
> *Enrico Granata* <egranata@🍎.com>
>
> On Feb 19, 2014, at 8:36 AM, Ed Maste <emaste at freebsd.org> wrote:
>
> On 18 February 2014 18:48, Enrico Granata <egranata at apple.com> wrote:
>
> Author: enrico
>
> Date: Tue Feb 18 17:48:11 2014
>
> New Revision: 201614
>
>
> URL: http://llvm.org/viewvc/llvm-project?rev=201614&view=rev
>
> Log:
>
> <rdar://problem/15960553>
>
>
> Fix a bug where calling SBFrame::FindValue() would cause a copy of all
> variables in the block to be inserted in the frame's variable list,
> regardless of whether those same variables were there or not - which means
> one could end up with a frame with lots of duplicate copies of the same
> variables
>
>
> After this change I see 10 new test failures (listed below); I haven't
> yet investigated if the tests are buggy, or if something else is now
> broken.
>
> test_access_my_int_with_dwarf TestProcessAPI ProcessAPITestCase
> test_read_memory_with_dwarf TestProcessAPI ProcessAPITestCase
> test_set_watch_ignore_count_with_dwarf TestWatchpointIgnoreCount
> WatchpointIgnoreCountTestCase
> test_watch_address_with_dwarf TestTargetWatchAddress
> TargetWatchAddressAPITestCase
> test_watch_iter_with_dwarf TestWatchpointIter WatchpointIteratorTestCase
> test_watch_location_with_dwarf TestSetWatchlocation
> SetWatchlocationAPITestCase
> test_watch_val_with_dwarf TestSetWatchpoint SetWatchpointAPITestCase
> test_watchpoint_cond_api_with_dwarf TestWatchpointConditionAPI
> WatchpointConditionAPITestCase
> test_with_dwarf_and_python_api TestStaticVariables StaticVariableTestCase
> test_write_memory_with_dwarf TestProcessAPI ProcessAPITestCase
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>
>


-- 
Todd Fiala | Software Engineer | tfiala at google.com | 650-943-3180
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140219/1ae93e6d/attachment.html>