[Lldb-commits] [lldb] r200875 - Fixed output to display correctly for "command source" by fixing the correct flags being set.

[Todd Fiala]

We've had that issue locally as well on Ubuntu 12.04.  I ran what the test
was trying to do manually and that worked, and also validated (added an
assert) that the file being loaded in exists (which it does).


On Thu, Feb 6, 2014 at 1:44 PM, Ed Maste <emaste at freebsd.org> wrote:

> On 5 February 2014 16:03, Greg Clayton <gclayton at apple.com> wrote:
> > Author: gclayton
> > Date: Wed Feb  5 15:03:22 2014
> > New Revision: 200875
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=200875&view=rev
> > Log:
> > Fixed output to display correctly for "command source" by fixing the
> correct flags being set.
> >
> > Also emit the "Executing commands" message so it properly only comes out
> when desired and so it comes out in the right place.
>
> test_nonrunning_command_abbreviations fails for me after this change,
> as follows:
>
> =========
> Executing commands in
>
> '/tank/emaste/src/llvm/tools/lldb/test/functionalities/abbreviation/change_prompt.lldb'.
> (lldb) settings set prompt "[with-three-trailing-spaces]   "
> runCmd: com sou ./change_prompt.lldb
> output:
>
> Expecting pattern: Executing commands in '.*change_prompt.lldb'
> Not matched
>
> FAILURE
> =========
>
> Perhaps the test incorrectly relies on the previous (broken)
> "Executing commands" output behaviour?  It seems odd to me though that
> "Executing commands" is still emitted but seems to come before the
> runCmd output.
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>



-- 
Todd Fiala | Software Engineer | tfiala at google.com | 650-943-3180
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20140206/e963f771/attachment.html>