[Lldb-commits] [PATCH] FreeBSD threaded inferior support

Ed Maste emaste at freebsd.org
Wed Nov 27 07:39:27 PST 2013



================
Comment at: source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp:167
@@ +166,3 @@
+        m_monitor->ThreadSuspend(*t_pos, true);
+        do_step = true;
+    }
----------------
Ed Maste wrote:
> John asks
> > What is the function of the "do_step = true" in the "m_suspended_tids" loop?
> 
> Good catch; I think I had the impression PT_CONTINUE would unsuspend all threads. Looking now though it doesn't look like it should be there, will test without it.
> 
> (It could have been a cut-and-pasteo, too.)
> 
Ahh, running the test with do_step = true removed causes the test to hang in the step_out test (which does "continue" on 2 of 3 threads).  I'll leave it in for now, and we may need a kernel change to support this fully.


http://llvm-reviews.chandlerc.com/D2267



More information about the lldb-commits mailing list