[Lldb-commits] [lldb] r194122 - Rename extended backtrace methods to take out the "ThreadOrigin"

Jason Molenda jmolenda at apple.com
Tue Nov 5 19:07:34 PST 2013


Author: jmolenda
Date: Tue Nov  5 21:07:33 2013
New Revision: 194122

URL: http://llvm.org/viewvc/llvm-project?rev=194122&view=rev
Log:
Rename extended backtrace methods to take out the "ThreadOrigin"
bit from the method names.
<rdar://problem/15314369> 

Modified:
    lldb/trunk/include/lldb/API/SBProcess.h
    lldb/trunk/include/lldb/API/SBThread.h
    lldb/trunk/include/lldb/Target/SystemRuntime.h
    lldb/trunk/scripts/Python/interface/SBProcess.i
    lldb/trunk/scripts/Python/interface/SBThread.i
    lldb/trunk/source/API/SBProcess.cpp
    lldb/trunk/source/API/SBThread.cpp
    lldb/trunk/source/Target/SystemRuntime.cpp

Modified: lldb/trunk/include/lldb/API/SBProcess.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/API/SBProcess.h?rev=194122&r1=194121&r2=194122&view=diff
==============================================================================
--- lldb/trunk/include/lldb/API/SBProcess.h (original)
+++ lldb/trunk/include/lldb/API/SBProcess.h Tue Nov  5 21:07:33 2013
@@ -283,7 +283,7 @@ public:
     ///   available.
     //------------------------------------------------------------------
     uint32_t
-    GetNumThreadOriginExtendedBacktraceTypes ();
+    GetNumExtendedBacktraceTypes ();
 
     //------------------------------------------------------------------
     /// Return the name of one of the thread-origin extended backtrace 
@@ -299,7 +299,7 @@ public:
     ///   The name at that index.
     //------------------------------------------------------------------
     const char *
-    GetThreadOriginExtendedBacktraceTypeAtIndex (uint32_t idx);
+    GetExtendedBacktraceTypeAtIndex (uint32_t idx);
 
 protected:
     friend class SBAddress;

Modified: lldb/trunk/include/lldb/API/SBThread.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/API/SBThread.h?rev=194122&r1=194121&r2=194122&view=diff
==============================================================================
--- lldb/trunk/include/lldb/API/SBThread.h (original)
+++ lldb/trunk/include/lldb/API/SBThread.h Tue Nov  5 21:07:33 2013
@@ -202,7 +202,7 @@ public:
     GetStatus (lldb::SBStream &status) const;
 
     SBThread
-    GetThreadOriginExtendedBacktrace (const char *type);
+    GetExtendedBacktrace (const char *type);
 
 protected:
     friend class SBBreakpoint;

Modified: lldb/trunk/include/lldb/Target/SystemRuntime.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Target/SystemRuntime.h?rev=194122&r1=194121&r2=194122&view=diff
==============================================================================
--- lldb/trunk/include/lldb/Target/SystemRuntime.h (original)
+++ lldb/trunk/include/lldb/Target/SystemRuntime.h Tue Nov  5 21:07:33 2013
@@ -128,7 +128,7 @@ public:
     ///   backtrace capabilities are available.
     //------------------------------------------------------------------
     virtual std::vector<ConstString>
-    GetThreadOriginExtendedBacktraceTypes ();
+    GetExtendedBacktraceTypes ();
 
     //------------------------------------------------------------------
     /// Return a Thread which shows the origin of this thread's creation.
@@ -147,7 +147,7 @@ public:
     ///
     /// @param [in] type
     ///   The type of thread origin being requested.  The types supported
-    ///   are returned from SystemRuntime::GetThreadOriginExtendedBacktraceTypes.
+    ///   are returned from SystemRuntime::GetExtendedBacktraceTypes.
     ///
     /// @return
     ///   A ThreadSP which will have a StackList of frames.  This Thread will
@@ -158,7 +158,7 @@ public:
     ///   An empty ThreadSP will be returned if no thread origin is available.
     //------------------------------------------------------------------
     virtual lldb::ThreadSP
-    GetThreadOriginExtendedBacktrace (lldb::ThreadSP thread, ConstString type);
+    GetExtendedBacktrace (lldb::ThreadSP thread, ConstString type);
 
 protected:
     //------------------------------------------------------------------

Modified: lldb/trunk/scripts/Python/interface/SBProcess.i
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/scripts/Python/interface/SBProcess.i?rev=194122&r1=194121&r2=194122&view=diff
==============================================================================
--- lldb/trunk/scripts/Python/interface/SBProcess.i (original)
+++ lldb/trunk/scripts/Python/interface/SBProcess.i Tue Nov  5 21:07:33 2013
@@ -361,18 +361,18 @@ public:
     able to show a backtrace of when that thread was originally created,
     or the work item was enqueued to it (in the case of a libdispatch 
     queue).
-    ") GetNumThreadOriginExtendedBacktraceTypes;
+    ") GetNumExtendedBacktraceTypes;
     
     uint32_t
-    GetNumThreadOriginExtendedBacktraceTypes ();
+    GetNumExtendedBacktraceTypes ();
 
     %feature("autodoc", "
     Takes an index argument, returns the name of one of the thread-origin 
     extended backtrace methods as a str.
-    ") GetThreadOriginExtendedBacktraceTypeAtIndex;
+    ") GetExtendedBacktraceTypeAtIndex;
 
     const char *
-    GetThreadOriginExtendedBacktraceTypeAtIndex (uint32_t idx);
+    GetExtendedBacktraceTypeAtIndex (uint32_t idx);
 
     %pythoncode %{
         def __get_is_alive__(self):

Modified: lldb/trunk/scripts/Python/interface/SBThread.i
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/scripts/Python/interface/SBThread.i?rev=194122&r1=194121&r2=194122&view=diff
==============================================================================
--- lldb/trunk/scripts/Python/interface/SBThread.i (original)
+++ lldb/trunk/scripts/Python/interface/SBThread.i Tue Nov  5 21:07:33 2013
@@ -249,9 +249,9 @@ public:
     normal threads -- you cannot step or resume it, for instance -- it is
     intended to used primarily for generating a backtrace.  You may request
     the returned thread's own thread origin in turn.
-    ") GetThreadOriginExtendedBacktrace;
+    ") GetExtendedBacktrace;
     lldb::SBThread
-    GetThreadOriginExtendedBacktrace (const char *type);
+    GetExtendedBacktrace (const char *type);
 
     %pythoncode %{
         class frames_access(object):

Modified: lldb/trunk/source/API/SBProcess.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/API/SBProcess.cpp?rev=194122&r1=194121&r2=194122&view=diff
==============================================================================
--- lldb/trunk/source/API/SBProcess.cpp (original)
+++ lldb/trunk/source/API/SBProcess.cpp Tue Nov  5 21:07:33 2013
@@ -1260,25 +1260,25 @@ SBProcess::UnloadImage (uint32_t image_t
 }
 
 uint32_t
-SBProcess::GetNumThreadOriginExtendedBacktraceTypes ()
+SBProcess::GetNumExtendedBacktraceTypes ()
 {
     ProcessSP process_sp(GetSP());
     if (process_sp && process_sp->GetSystemRuntime())
     {
         SystemRuntime *runtime = process_sp->GetSystemRuntime();
-        return runtime->GetThreadOriginExtendedBacktraceTypes().size();
+        return runtime->GetExtendedBacktraceTypes().size();
     }
     return 0;
 }
 
 const char *
-SBProcess::GetThreadOriginExtendedBacktraceTypeAtIndex (uint32_t idx)
+SBProcess::GetExtendedBacktraceTypeAtIndex (uint32_t idx)
 {
     ProcessSP process_sp(GetSP());
     if (process_sp && process_sp->GetSystemRuntime())
     {
         SystemRuntime *runtime = process_sp->GetSystemRuntime();
-        std::vector<ConstString> names = runtime->GetThreadOriginExtendedBacktraceTypes();
+        std::vector<ConstString> names = runtime->GetExtendedBacktraceTypes();
         if (idx < names.size())
         {
             return names[idx].AsCString();
@@ -1287,7 +1287,7 @@ SBProcess::GetThreadOriginExtendedBacktr
         {
             Log *log(lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_API));
             if (log)
-                log->Printf("SBProcess(%p)::GetThreadOriginExtendedBacktraceTypeAtIndex() => error: requested extended backtrace name out of bounds", process_sp.get());
+                log->Printf("SBProcess(%p)::GetExtendedBacktraceTypeAtIndex() => error: requested extended backtrace name out of bounds", process_sp.get());
         }
     }
     return NULL;

Modified: lldb/trunk/source/API/SBThread.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/API/SBThread.cpp?rev=194122&r1=194121&r2=194122&view=diff
==============================================================================
--- lldb/trunk/source/API/SBThread.cpp (original)
+++ lldb/trunk/source/API/SBThread.cpp Tue Nov  5 21:07:33 2013
@@ -1283,7 +1283,7 @@ SBThread::GetDescription (SBStream &desc
 }
 
 SBThread
-SBThread::GetThreadOriginExtendedBacktrace (const char *type)
+SBThread::GetExtendedBacktrace (const char *type)
 {
     Log *log(lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_API));
     Mutex::Locker api_locker;
@@ -1302,7 +1302,7 @@ SBThread::GetThreadOriginExtendedBacktra
                 SystemRuntime *runtime = exe_ctx.GetProcessPtr()->GetSystemRuntime();
                 if (runtime)
                 {
-                    ThreadSP origin_thread = runtime->GetThreadOriginExtendedBacktrace (real_thread, type_const);
+                    ThreadSP origin_thread = runtime->GetExtendedBacktrace (real_thread, type_const);
                     sb_origin_thread.SetThread (origin_thread);
                 }
             }
@@ -1310,7 +1310,7 @@ SBThread::GetThreadOriginExtendedBacktra
         else
         {
             if (log)
-                log->Printf ("SBThread(%p)::GetThreadOriginExtendedBacktrace() => error: process is running", exe_ctx.GetThreadPtr());
+                log->Printf ("SBThread(%p)::GetExtendedBacktrace() => error: process is running", exe_ctx.GetThreadPtr());
         }
     }
 

Modified: lldb/trunk/source/Target/SystemRuntime.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/SystemRuntime.cpp?rev=194122&r1=194121&r2=194122&view=diff
==============================================================================
--- lldb/trunk/source/Target/SystemRuntime.cpp (original)
+++ lldb/trunk/source/Target/SystemRuntime.cpp Tue Nov  5 21:07:33 2013
@@ -60,14 +60,14 @@ SystemRuntime::ModulesDidLoad (ModuleLis
 }
 
 std::vector<ConstString>
-SystemRuntime::GetThreadOriginExtendedBacktraceTypes ()
+SystemRuntime::GetExtendedBacktraceTypes ()
 {
     std::vector<ConstString> types;
     return types;
 }
 
 ThreadSP
-SystemRuntime::GetThreadOriginExtendedBacktrace (ThreadSP thread, ConstString type)
+SystemRuntime::GetExtendedBacktrace (ThreadSP thread, ConstString type)
 {
     return ThreadSP();
 }





More information about the lldb-commits mailing list