[Lldb-commits] [PATCH] LLDB Command line driver windows changes.

Richard Mitton richard at codersnotes.com
Thu Oct 10 11:45:09 PDT 2013


  Why does this replace a condition variable with a 10 millisecond
  spinlock? Spinlocks are bad.

  I don't know about the C++11 standard, but if you want the same effect
  on Windows you'd just use SetEvent.

  Also don't use volatile. In fact, never use volatile. m_output_flushed
  is a class variable, so the compiler knows to reload it each time anyway.

  Richard Mitton
  richard at codersnotes.com

http://llvm-reviews.chandlerc.com/D1785



More information about the lldb-commits mailing list