[Lldb-commits] MSVC12 support

João Matos ripzonetriton at gmail.com
Wed Aug 28 09:07:18 PDT 2013


+#ifdef _MSC_VER
+        InterlockedIncrement(&m_last_revision);
+#else
         __sync_add_and_fetch(&m_last_revision, +1);
+#endif

I see this pattern ifdef'd in a lot of places, I think we should abstract
it in an helper "atomics" function, or even better, just re-use LLVM
support libraries
(llvm::sys::AtomicIncrement<http://llvm.org/docs/doxygen/html/namespacellvm_1_1sys.html#a40e1bab8b13b891dfb830c16c58a44cb>
).


-- 
João Matos
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20130828/e0aaa53b/attachment.html>


More information about the lldb-commits mailing list