[Lldb-commits] m_private_run_lock relying on undefined pthread behaviour

[Greg Clayton]

It looks good as far as I can tell. I am running the darwin test suite now with this patch. I will let you know.

Greg

On Jul 26, 2013, at 12:44 PM, Ed Maste <emaste at freebsd.org> wrote:

> On 25 July 2013 17:07, Ed Maste <emaste at freebsd.org> wrote:
>> On 3 July 2013 10:21, Ed Maste <emaste at freebsd.org> wrote:
>>> On 18 June 2013 18:45, Greg Clayton <gclayton at apple.com> wrote:
>>>> Yes we do rely upon being able to lock on one thread and unlock on another. Good catch, let us know what you come up with.
>>>> 
>>>> Greg
>>> 
>>> I finally had a chance to look at this, and have a proof of concept
>>> change.  Here's the commit message from my tree:
>> 
>> I've cleaned it up a bit and uploaded it to
>> http://llvm-reviews.chandlerc.com/D1208.
> 
> I tested my patch on my Debian VM, but the tests hang with and without
> the patch.  Dan tested it on Ubuntu with apparent success (a couple of
> failures seemingly unrelated to this code).
> 
> It's pretty straightforward but I'd like more review; I see there's
> been trouble with deadlocks etc. related to the run locks in the past,
> and so I'd like to proceed cautiously.
> 
> -Ed