[Lldb-commits] [lldb] r186363 - Fixed a problem in IRForTarget where we would not

[Sean Callanan]

Author: spyffe
Date: Mon Jul 15 18:31:47 2013
New Revision: 186363

URL: http://llvm.org/viewvc/llvm-project?rev=186363&view=rev
Log:
Fixed a problem in IRForTarget where we would not
delete a constant after we replaced it with a
dynamically-computed value.  Also ensured that we
replace all users of the constant if there are
multiple ones.  Added a testcase.

<rdar://problem/14379043>

Added:
    lldb/trunk/test/lang/objc/objc-struct-return/
    lldb/trunk/test/lang/objc/objc-struct-return/Makefile
    lldb/trunk/test/lang/objc/objc-struct-return/TestObjCStructReturn.py
    lldb/trunk/test/lang/objc/objc-struct-return/test.m
Modified:
    lldb/trunk/source/Expression/IRForTarget.cpp

Modified: lldb/trunk/source/Expression/IRForTarget.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/IRForTarget.cpp?rev=186363&r1=186362&r2=186363&view=diff
==============================================================================
--- lldb/trunk/source/Expression/IRForTarget.cpp (original)
+++ lldb/trunk/source/Expression/IRForTarget.cpp Mon Jul 15 18:31:47 2013
@@ -2210,7 +2210,8 @@ IRForTarget::UnfoldConstant(Constant *ol
                                                    llvm::cast<Instruction>(entry_instruction_finder.GetValue(function)));
                         });
                         
-                        return UnfoldConstant(constant_expr, bit_cast_maker, entry_instruction_finder);
+                        if (!UnfoldConstant(constant_expr, bit_cast_maker, entry_instruction_finder))
+                            return false;
                     }
                     break;
                 case Instruction::GetElementPtr:
@@ -2247,7 +2248,8 @@ IRForTarget::UnfoldConstant(Constant *ol
                             return GetElementPtrInst::Create(ptr, indices, "", llvm::cast<Instruction>(entry_instruction_finder.GetValue(function)));
                         });
                         
-                        return UnfoldConstant(constant_expr, get_element_pointer_maker, entry_instruction_finder);
+                        if (!UnfoldConstant(constant_expr, get_element_pointer_maker, entry_instruction_finder))
+                            return false;
                     }
                     break;
                 }
@@ -2274,6 +2276,11 @@ IRForTarget::UnfoldConstant(Constant *ol
         }
     }
     
+    if (!isa<GlobalValue>(old_constant))
+    {
+        old_constant->destroyConstant();
+    }
+    
     return true;
 }
 

Added: lldb/trunk/test/lang/objc/objc-struct-return/Makefile
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/lang/objc/objc-struct-return/Makefile?rev=186363&view=auto
==============================================================================
--- lldb/trunk/test/lang/objc/objc-struct-return/Makefile (added)
+++ lldb/trunk/test/lang/objc/objc-struct-return/Makefile Mon Jul 15 18:31:47 2013
@@ -0,0 +1,6 @@
+LEVEL = ../../../make
+
+OBJC_SOURCES := test.m
+LDFLAGS = $(CFLAGS) -lobjc -framework Foundation
+
+include $(LEVEL)/Makefile.rules

Added: lldb/trunk/test/lang/objc/objc-struct-return/TestObjCStructReturn.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/lang/objc/objc-struct-return/TestObjCStructReturn.py?rev=186363&view=auto
==============================================================================
--- lldb/trunk/test/lang/objc/objc-struct-return/TestObjCStructReturn.py (added)
+++ lldb/trunk/test/lang/objc/objc-struct-return/TestObjCStructReturn.py Mon Jul 15 18:31:47 2013
@@ -0,0 +1,69 @@
+"""Test calling functions in class methods."""
+
+import os, time
+import unittest2
+import lldb
+import lldbutil
+from lldbtest import *
+
+class TestObjCClassMethod(TestBase):
+
+    mydir = os.path.join("lang", "objc", "objc-class-method")
+
+    @unittest2.skipUnless(sys.platform.startswith("darwin"), "requires Darwin")
+    @python_api_test
+    @dsym_test
+    def test_with_dsym_and_python_api(self):
+        """Test calling functions in class methods."""
+        self.buildDsym()
+        self.objc_class_method()
+
+    @unittest2.skipUnless(sys.platform.startswith("darwin"), "requires Darwin")
+    @python_api_test
+    @dwarf_test
+    def test_with_dwarf_and_python_api(self):
+        """Test calling functions in class methods."""
+        self.buildDwarf()
+        self.objc_class_method()
+
+    def setUp(self):
+        # Call super's setUp().
+        TestBase.setUp(self)
+        # Find the line numbers to break inside main().
+        self.main_source = "class.m"
+        self.break_line = line_number(self.main_source, '// Set breakpoint here.')
+
+    def objc_class_method(self):
+        """Test calling class methods."""
+        exe = os.path.join(os.getcwd(), "a.out")
+
+        target = self.dbg.CreateTarget(exe)
+        self.assertTrue(target, VALID_TARGET)
+
+        bpt = target.BreakpointCreateByLocation(self.main_source, self.break_line)
+        self.assertTrue(bpt, VALID_BREAKPOINT)
+
+        # Now launch the process, and do not stop at entry point.
+        process = target.LaunchSimple (None, None, os.getcwd())
+
+        self.assertTrue(process, PROCESS_IS_VALID)
+
+        # The stop reason of the thread should be breakpoint.
+        thread_list = lldbutil.get_threads_stopped_at_breakpoint (process, bpt)
+
+        # Make sure we stopped at the first breakpoint.
+        self.assertTrue (len(thread_list) != 0, "No thread stopped at our breakpoint.")
+        self.assertTrue (len(thread_list) == 1, "More than one thread stopped at our breakpoint.")
+            
+        frame = thread_list[0].GetFrameAtIndex(0)
+        self.assertTrue (frame, "Got a valid frame 0 frame.")
+
+        # Now make sure we can call a method that returns a struct without crashing.
+        cmd_value = frame.EvaluateExpression ("[provider getRange]")
+        self.assertTrue (cmd_value.IsValid())
+
+if __name__ == '__main__':
+    import atexit
+    lldb.SBDebugger.Initialize()
+    atexit.register(lambda: lldb.SBDebugger.Terminate())
+    unittest2.main()

Added: lldb/trunk/test/lang/objc/objc-struct-return/test.m
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/lang/objc/objc-struct-return/test.m?rev=186363&view=auto
==============================================================================
--- lldb/trunk/test/lang/objc/objc-struct-return/test.m (added)
+++ lldb/trunk/test/lang/objc/objc-struct-return/test.m Mon Jul 15 18:31:47 2013
@@ -0,0 +1,23 @@
+#import <Foundation/Foundation.h>
+
+ at interface RangeProvider : NSObject {
+};
+-(NSRange)getRange;
+ at end
+
+ at implementation RangeProvider
+-(NSRange)getRange
+{
+  return NSMakeRange(0, 3);
+}
+ at end
+
+int main()
+{
+  @autoreleasepool
+  {
+    RangeProvider *provider = [RangeProvider alloc];
+    NSRange range = [provider getRange]; // Set breakpoint here.
+    return 0;
+  }
+}