[Lldb-commits] MinGW compilation support

[Malea, Daniel]

I also looked at the patches and they seem fine. Nice to see both cmake/autotool support!

A minor nit: the filename in the comment at the top of windows/Host.cpp is wrong (it references the linux file, which threw me off a little).

Otherwise I think it's fine. Good to see another platform get support :)


Cheers,
Dan

From: Virgile Bello <virgile.bello at gmail.com<mailto:virgile.bello at gmail.com>>
Date: Monday, 8 July, 2013 5:27 AM
To: Carlo Kok <ck at remobjects.com<mailto:ck at remobjects.com>>
Cc: "lldb-commits at cs.uiuc.edu<mailto:lldb-commits at cs.uiuc.edu>" <lldb-commits at cs.uiuc.edu<mailto:lldb-commits at cs.uiuc.edu>>
Subject: Re: [Lldb-commits] MinGW compilation support

Ha yes I remember this part.
I delayed it because I wasn't sure if it might not be better to handle this translation directly in Error class (i.e. error.GetSocketError() with specific Windows implementation). That would avoid lot of #ifdef in all socket code.


On Mon, Jul 8, 2013 at 3:54 PM, Carlo Kok <ck at remobjects.com<mailto:ck at remobjects.com>> wrote:
Op 7-7-2013 11:44, Virgile Bello schreef:

Here is a patch allowing compilation of LLDB with MinGW.
(it still compiles on Linux after the patch)
Can someone please review (and merge in trunk if everything seems good)?

Soon some other patches should follow:
- 1 for MSVC compilation
- 1 to add a lldbProcessWindows using Win32 debugging API, so that
gdb/clang compiled programs can be debugged in Windows.

Hopefully I can get all this into trunk quickly so that I don't need to
rebase/merge too much.
Thanks!


Patch looks good. the only thing I'm missing is the error handing in ConnectionFileDescriptor.cpp, though that can be done as an incremental patch (Windows sockets return WSAWOULDBLOCK instead of EAGAIN etc), see:
http://llvm.org/svn/llvm-project/lldb/branches/windows/source/Core/ConnectionFileDescriptor.cpp

in the Windows part.