[Lldb-commits] [lldb] r184877 - Fix undefined behaviour in data formatter test -- ensure char* null-terminated

Tim Northover tnorthover at apple.com
Tue Jun 25 15:15:22 PDT 2013


On Tuesday 25 June 2013 14:52:27 Enrico Granata wrote:
> While I think that the test case was coping quite well with the randomness
> of the input, feel free to elaborate on why you feel there is a data
> formatters issue in this scenario

My main worry was what the consequences for a user of hitting this undefined 
behaviour are, since it's entirely possible a user will have such code. The UB 
reference was what worried me, since that could crash lldb or have similarly 
bad consequences.

I'm still unsure quite what could happen, but I'll believe everyone's 
reassurances that it's not a problem.

Cheers.

Tim.



More information about the lldb-commits mailing list