[Lldb-commits] [lldb] r184765 - We set the error when a breakpoint condition

Sean Callanan scallanan at apple.com
Mon Jun 24 10:58:46 PDT 2013


Author: spyffe
Date: Mon Jun 24 12:58:46 2013
New Revision: 184765

URL: http://llvm.org/viewvc/llvm-project?rev=184765&view=rev
Log:
We set the error when a breakpoint condition
doesn't return anything; that's great.

We should probably also return rather than
trying to access the nonexistent return value.

<rdar://problem/14009519>

Modified:
    lldb/trunk/source/Breakpoint/BreakpointLocation.cpp

Modified: lldb/trunk/source/Breakpoint/BreakpointLocation.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Breakpoint/BreakpointLocation.cpp?rev=184765&r1=184764&r2=184765&view=diff
==============================================================================
--- lldb/trunk/source/Breakpoint/BreakpointLocation.cpp (original)
+++ lldb/trunk/source/Breakpoint/BreakpointLocation.cpp Mon Jun 24 12:58:46 2013
@@ -319,6 +319,7 @@ BreakpointLocation::ConditionSaysStop (E
         {
             ret = false;
             error.SetErrorString("Expression did not return a result");
+            return false;
         }
         
         result_value_sp = result_variable_sp->GetValueObject();





More information about the lldb-commits mailing list