[Lldb-commits] Patch for Review: Add new Linux auxv types

[Greg Clayton]

If the defines vary between target triples, you might need to pass the ArchSpec into the function from the process. Then the code can check the ArchSpec.GetTriple() (which gives you an llvm::Triple) so you can check for FreeBSD/Linux and it can do the right thing for both. 

There will be remote debugging soon in the future and these DYLD plug-ins are not tied to the current host are they?

On Jun 17, 2013, at 10:41 AM, Ed Maste <emaste at freebsd.org> wrote:

> On 17 June 2013 13:17, Kopec, Matt <matt.kopec at intel.com> wrote:
>> Looks good to me. I guess these are taken from elf.h?
>> 
>> Ed: Any comments from the FreeBSD side?
> 
> Hmm, it looks like this will be a bit tricky for future
> rationalization; looking at FreeBSD's elf.h I see they diverge after
> AT_EGID:
> 
> #define AT_EXECPATH     15      /* Path to the executable. */
> #define AT_CANARY       16      /* Canary for SSP. */
> #define AT_CANARYLEN    17      /* Length of the canary. */
> #define AT_OSRELDATE    18      /* OSRELDATE. */
> #define AT_NCPUS        19      /* Number of CPUs. */
> #define AT_PAGESIZES    20      /* Pagesizes. */
> #define AT_PAGESIZESLEN 21      /* Number of pagesizes. */
> #define AT_TIMEKEEP     22      /* Pointer to timehands. */
> #define AT_STACKPROT    23      /* Initial stack protection. */
> 
> #define AT_COUNT        24      /* Count of defined aux entry types. */
> 
> (from http://svnweb.freebsd.org/base/head/sys/x86/include/elf.h?revision=247047&view=markup)
> 
> However there is already a conflict, so I have no objection to this
> addition.  I'll probably submit an #ifdef patch in the short term for
> the FreeBSD values, but will have to ponder Linux-FreeBSD or
> FreeBSD-Linux cross debugging later.
> 
> -Ed
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits