[Lldb-commits] [lldb] r183049 - Add ability to attach/detach to multi-threaded inferiors on Linux.

Kopec, Matt matt.kopec at intel.com
Mon Jun 3 11:52:50 PDT 2013


Oops, sorry about that. Thanks for the fix.

On 2013-06-03, at 2:15 PM, Ed Maste <emaste at freebsd.org> wrote:

> On 31 May 2013 18:00, Matt Kopec <Matt.Kopec at intel.com> wrote:
>> Author: mkopec
>> Date: Fri May 31 17:00:07 2013
>> New Revision: 183049
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=183049&view=rev
>> Log:
>> Add ability to attach/detach to multi-threaded inferiors on Linux.
>> All running threads will be detected and stopped on attach and all threads get resumed on detach.
> 
> This broke the FreeBSD build; I used the trivial change below to restore it.
> 
> Index: source/Plugins/Process/FreeBSD/ProcessMonitor.cpp
> ===================================================================
> --- source/Plugins/Process/FreeBSD/ProcessMonitor.cpp   (revision 183139)
> +++ source/Plugins/Process/FreeBSD/ProcessMonitor.cpp   (working copy)
> @@ -1551,7 +1551,7 @@
> }
> 
> Error
> -ProcessMonitor::Detach()
> +ProcessMonitor::Detach(lldb::tid_t tid)
> {
>     Error result;
>     DetachOperation op(result);
> Index: source/Plugins/Process/FreeBSD/ProcessMonitor.h
> ===================================================================
> --- source/Plugins/Process/FreeBSD/ProcessMonitor.h     (revision 183139)
> +++ source/Plugins/Process/FreeBSD/ProcessMonitor.h     (working copy)
> @@ -188,7 +188,7 @@
>     BringProcessIntoLimbo();
> 
>     lldb_private::Error
> -    Detach();
> +    Detach(lldb::tid_t tid);
> 
> 
> private:





More information about the lldb-commits mailing list