[Lldb-commits] PATCH for REVIEW: parse ansi color codes for prompt, add use color settings
daniel.malea at intel.com
Thu May 23 13:07:41 PDT 2013
Yeah, that's a great workflow. We don't want to make things harder for
folks that review patches via email, so it's best to continue to post
patches to the lists as well as you've done already.
Also, if you want to speed things up when using phabricator, there's the
"arc" command line tool that makes it super easy to turn git branches into
reviews, and reviews into git branches :)
On 2013-05-23 4:00 PM, "Mike Sartain" <mikesart at valvesoftware.com> wrote:
>From: Malea, Daniel [daniel.malea at intel.com]
>> Hi Mike, this looks promising! I'm having some difficulty applying this
>>patch on the latest trunk though; seeing a conflict in AnsiTerminal.h.
>> As an aside, lldb folk don't seem to use this much, but if you have a
>>git workflow, I found LLVM reviews to be pretty painless through the
>>"phabricator" instance that's been set up. If you haven't seen it, check
>How does this look?
>And this is the Linux "platform process list" one...
>The UI on chandlerc.com is really slick. So is it best to create a diff
>there (like the two above) and then send e-mail to the lldb-commits alias
>for review before checking in?
More information about the lldb-commits