[Lldb-commits] [lldb] r182069 - Comment out ObjectFileELF::GetModuleSpecifications() function until I can debug where it's causing tests to fail.

Michael Sartain mikesart at valvesoftware.com
Thu May 16 19:00:55 PDT 2013


Author: mikesart
Date: Thu May 16 21:00:55 2013
New Revision: 182069

URL: http://llvm.org/viewvc/llvm-project?rev=182069&view=rev
Log:
Comment out ObjectFileELF::GetModuleSpecifications() function until I can debug where it's causing tests to fail.

Modified:
    lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

Modified: lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp?rev=182069&r1=182068&r2=182069&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp (original)
+++ lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp Thu May 16 21:00:55 2013
@@ -243,8 +243,11 @@ ObjectFileELF::GetModuleSpecifications (
                                         lldb::offset_t length,
                                         lldb_private::ModuleSpecList &specs)
 {
+// FIXME: mikesart at valvesoftware.com
+// Implementing this function has broken several tests. Specifically this one:
+// Python dotest.py --executable <path-to-lldb> -p TestCallStdStringFunction.py
     const size_t initial_count = specs.GetSize();
-    
+#if 0    
     if (ObjectFileELF::MagicBytesMatch(data_sp, 0, data_sp->GetByteSize()))
     {
         DataExtractor data;
@@ -269,6 +272,7 @@ ObjectFileELF::GetModuleSpecifications (
             }
         }
     }
+#endif
     return specs.GetSize() - initial_count;
 }
 





More information about the lldb-commits mailing list