[Lldb-commits] [lldb] r180829 - Make "process handle -n true -s false" actually notifies of the signal.

Jim Ingham jingham at apple.com
Tue Apr 30 16:42:25 PDT 2013


Author: jingham
Date: Tue Apr 30 18:42:24 2013
New Revision: 180829

URL: http://llvm.org/viewvc/llvm-project?rev=180829&view=rev
Log:
Make "process handle -n true -s false" actually notifies of the signal.

rdar://problem/12020085

Modified:
    lldb/trunk/include/lldb/Target/ThreadPlanBase.h
    lldb/trunk/source/Target/ThreadPlanBase.cpp

Modified: lldb/trunk/include/lldb/Target/ThreadPlanBase.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Target/ThreadPlanBase.h?rev=180829&r1=180828&r2=180829&view=diff
==============================================================================
--- lldb/trunk/include/lldb/Target/ThreadPlanBase.h (original)
+++ lldb/trunk/include/lldb/Target/ThreadPlanBase.h Tue Apr 30 18:42:24 2013
@@ -37,6 +37,7 @@ public:
     virtual bool ValidatePlan (Stream *error);
     virtual bool PlanExplainsStop (Event *event_ptr);
     virtual bool ShouldStop (Event *event_ptr);
+    virtual Vote ShouldReportStop (Event *event_ptr);
     virtual bool StopOthers ();
     virtual lldb::StateType GetPlanRunState ();
     virtual bool WillStop ();

Modified: lldb/trunk/source/Target/ThreadPlanBase.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/ThreadPlanBase.cpp?rev=180829&r1=180828&r2=180829&view=diff
==============================================================================
--- lldb/trunk/source/Target/ThreadPlanBase.cpp (original)
+++ lldb/trunk/source/Target/ThreadPlanBase.cpp Tue Apr 30 18:42:24 2013
@@ -78,6 +78,22 @@ ThreadPlanBase::PlanExplainsStop (Event
         return true;
 }
 
+Vote
+ThreadPlanBase::ShouldReportStop(Event *event_ptr)
+{
+    StopInfoSP stop_info_sp = GetPrivateStopReason();
+    if (stop_info_sp)
+    {
+        bool should_notify = stop_info_sp->ShouldNotify(event_ptr);
+        if (should_notify)
+            return eVoteYes;
+        else
+            return eVoteNoOpinion;
+    }
+    else
+        return eVoteNoOpinion;
+}
+
 bool
 ThreadPlanBase::ShouldStop (Event *event_ptr)
 {





More information about the lldb-commits mailing list