[Lldb-commits] [lldb] r177913 - <rdar://problem/13498879>

Greg Clayton gclayton at apple.com
Mon Mar 25 14:06:13 PDT 2013


Author: gclayton
Date: Mon Mar 25 16:06:13 2013
New Revision: 177913

URL: http://llvm.org/viewvc/llvm-project?rev=177913&view=rev
Log:
<rdar://problem/13498879> 

C String summary is emitting "<invalid usage of pointer value as object>" for bad pointers. Now it doesn't emit anything.


Modified:
    lldb/trunk/source/Core/Debugger.cpp

Modified: lldb/trunk/source/Core/Debugger.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/Debugger.cpp?rev=177913&r1=177912&r2=177913&view=diff
==============================================================================
--- lldb/trunk/source/Core/Debugger.cpp (original)
+++ lldb/trunk/source/Core/Debugger.cpp Mon Mar 25 16:06:13 2013
@@ -1557,8 +1557,7 @@ Debugger::FormatPrompt
                                     if (log)
                                         log->Printf("[Debugger::FormatPrompt] I am into array || pointer && !range");
                                     
-                                    if (target->HasSpecialPrintableRepresentation(val_obj_display,
-                                                                                  custom_format))
+                                    if (target->HasSpecialPrintableRepresentation(val_obj_display, custom_format))
                                     {
                                         // try to use the special cases
                                         var_success = target->DumpPrintableRepresentation(str_temp,
@@ -1568,9 +1567,7 @@ Debugger::FormatPrompt
                                             log->Printf("[Debugger::FormatPrompt] special cases did%s match", var_success ? "" : "n't");
                                         
                                         // should not happen
-                                        if (!var_success)
-                                            s << "<invalid usage of pointer value as object>";
-                                        else
+                                        if (var_success)
                                             s << str_temp.GetData();
                                         var_success = true;
                                         break;
@@ -1588,10 +1585,6 @@ Debugger::FormatPrompt
                                                                                  custom_format,
                                                                                  ValueObject::ePrintableRepresentationSpecialCasesDisable);
                                         }
-                                        else
-                                        {
-                                            s << "<invalid usage of pointer value as object>";
-                                        }
                                         var_success = true;
                                         break;
                                     }





More information about the lldb-commits mailing list