[Lldb-commits] [Patch][Please Review] Add support for GNU indirect functions

Kopec, Matt matt.kopec at intel.com
Fri Feb 15 16:49:24 PST 2013

So I resolved the bug in the symbol table parser for ELF and committed it earlier this week. Now I'm getting the correct (only one) symbol. I've reworked the patch to accommodate this fix and also added the suggestions made by Sean and yourself. I had to change a call when searching for symbols of type eSymbolTypeCode to look for eSymbolTypeAll then look for eSymbolTypeCode/eSymbolTypeResolver in the returned list. I had to do this in Module::FindFunctions otherwise the expression parser won't understand an expression with a indirect function call in it. I'm worried there may be other locations/situations where this is needed when searching for eSymbolTypeCode symbols and eSymbolTypeResolver should be searched as well but I don't know what those problems could be.

Do you mind reviewing the patch again?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: gnuindirectfuncsupport.patch
Type: application/octet-stream
Size: 22883 bytes
Desc: gnuindirectfuncsupport.patch
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20130216/3d4ed7fb/attachment.obj>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ATT00001.txt
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20130216/3d4ed7fb/attachment.txt>

More information about the lldb-commits mailing list