[Lldb-commits] [lldb] r174673 - Renaming SBValueList::get() to

Enrico Granata egranata at apple.com
Thu Feb 7 14:57:46 PST 2013


Author: enrico
Date: Thu Feb  7 16:57:46 2013
New Revision: 174673

URL: http://llvm.org/viewvc/llvm-project?rev=174673&view=rev
Log:
Renaming SBValueList::get() to 
opaque_ptr since it returns a void* instead of an usable object.

Modified:
    lldb/trunk/include/lldb/API/SBValueList.h
    lldb/trunk/source/API/SBFrame.cpp
    lldb/trunk/source/API/SBValueList.cpp

Modified: lldb/trunk/include/lldb/API/SBValueList.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/API/SBValueList.h?rev=174673&r1=174672&r2=174673&view=diff
==============================================================================
--- lldb/trunk/include/lldb/API/SBValueList.h (original)
+++ lldb/trunk/include/lldb/API/SBValueList.h Thu Feb  7 16:57:46 2013
@@ -54,8 +54,10 @@ public:
 
 protected:
     
+    // only useful for visualizing the pointer or comparing two SBValueLists
+    // to see if they are backed by the same underlying Impl.
     void *
-    get ();
+    opaque_ptr ();
 
 private:
     friend class SBFrame;

Modified: lldb/trunk/source/API/SBFrame.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/API/SBFrame.cpp?rev=174673&r1=174672&r2=174673&view=diff
==============================================================================
--- lldb/trunk/source/API/SBFrame.cpp (original)
+++ lldb/trunk/source/API/SBFrame.cpp Thu Feb  7 16:57:46 2013
@@ -1159,7 +1159,7 @@ SBFrame::GetVariables (bool arguments,
 
     if (log)
     {
-        log->Printf ("SBFrame(%p)::GetVariables (...) => SBValueList(%p)", frame, value_list.get());
+        log->Printf ("SBFrame(%p)::GetVariables (...) => SBValueList(%p)", frame, value_list.opaque_ptr());
     }
 
     return value_list;
@@ -1209,7 +1209,7 @@ SBFrame::GetRegisters ()
     }
 
     if (log)
-        log->Printf ("SBFrame(%p)::GetRegisters () => SBValueList(%p)", frame, value_list.get());
+        log->Printf ("SBFrame(%p)::GetRegisters () => SBValueList(%p)", frame, value_list.opaque_ptr());
 
     return value_list;
 }

Modified: lldb/trunk/source/API/SBValueList.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/API/SBValueList.cpp?rev=174673&r1=174672&r2=174673&view=diff
==============================================================================
--- lldb/trunk/source/API/SBValueList.cpp (original)
+++ lldb/trunk/source/API/SBValueList.cpp Thu Feb  7 16:57:46 2013
@@ -263,7 +263,7 @@ SBValueList::FindValueObjectByUID (lldb:
 }
 
 void *
-SBValueList::get ()
+SBValueList::opaque_ptr ()
 {
     return m_opaque_ap.get();
 }





More information about the lldb-commits mailing list