[Lldb-commits] [lldb] r173406 - /lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.h

Jason Molenda jmolenda at apple.com
Thu Jan 24 17:05:30 PST 2013


Author: jmolenda
Date: Thu Jan 24 19:05:30 2013
New Revision: 173406

URL: http://llvm.org/viewvc/llvm-project?rev=173406&view=rev
Log:
<rdar://problem/13072285> 

Change the GDBRemoteRegisterContext::AddRegister function to take
its RegisterInfo argument by value instead of using a reference -
it will modify the object and modifying the contents of the 
g_register_infos table in GDBRemoteRegisterContext.cpp can cause a
crash the next time we step through it.



Modified:
    lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.h

Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.h?rev=173406&r1=173405&r2=173406&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.h (original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.h Thu Jan 24 19:05:30 2013
@@ -46,7 +46,7 @@
     }
 
     void
-    AddRegister (lldb_private::RegisterInfo &reg_info, 
+    AddRegister (lldb_private::RegisterInfo reg_info, 
                  lldb_private::ConstString &reg_name, 
                  lldb_private::ConstString &reg_alt_name, 
                  lldb_private::ConstString &set_name)





More information about the lldb-commits mailing list