[Lldb-commits] [review request] fix test cases with hardcoded "-arch x86_64"

[Malea, Daniel]

Hi all,


There's a few test-cases with Makefiles that have "-arch x86_64" hardcoded. This makes it so the tests are only run on 64-bit mode and never on 32-bit mode. I have a patch that fixes this problem; see attached.

However, one of the test-cases (rdar122991846) causes lldb to crash when built with "-arch i386". It's currently marked as expected-to-fail on 64-bits. 

Is the patch OK to submit as-is? Should I disable the test-case in question, maybe with a "@skipIfi386" decorator? I only ask because actual crashes (as opposed to just failures) are very annoying, for us Linux folk at least, as they crash the entire "dotest.py" testing tool…. 



Cheers,
Dan