[Lldb-commits] [lldb] r169751 - in /lldb/trunk: examples/summaries/cocoa/NSNumber.py source/Core/CXXFormatterFunctions.cpp

Enrico Granata egranata at apple.com
Mon Dec 10 11:23:00 PST 2012


Author: enrico
Date: Mon Dec 10 13:23:00 2012
New Revision: 169751

URL: http://llvm.org/viewvc/llvm-project?rev=169751&view=rev
Log:
<rdar://problem/12817233>

Change the wording of NSNumber summary from absurd value to unexpected value when a tagged pointer shows up that does not match our knowledge of the internals


Modified:
    lldb/trunk/examples/summaries/cocoa/NSNumber.py
    lldb/trunk/source/Core/CXXFormatterFunctions.cpp

Modified: lldb/trunk/examples/summaries/cocoa/NSNumber.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/examples/summaries/cocoa/NSNumber.py?rev=169751&r1=169750&r2=169751&view=diff
==============================================================================
--- lldb/trunk/examples/summaries/cocoa/NSNumber.py (original)
+++ lldb/trunk/examples/summaries/cocoa/NSNumber.py Mon Dec 10 13:23:00 2012
@@ -54,7 +54,7 @@
 		if self.info_bits == 12:
 			return '(long)' + str(ctypes.c_long(self.data).value)
 		else:
-			return 'absurd value:(info=' + str(self.info_bits) + ", value = " + str(self.data) + ')'
+			return 'unexpected value:(info=' + str(self.info_bits) + ", value = " + str(self.data) + ')'
 
 
 class NSUntaggedNumber_SummaryProvider:
@@ -158,7 +158,7 @@
 			statistics.metric_hit('code_notrun',self.valobj)
 			return '(double)' + str(data_double)
 		statistics.metric_hit('unknown_class',str(valobj.GetName()) + " had unknown data_type " + str(data_type))
-		return 'absurd: dt = ' + str(data_type)
+		return 'unexpected: dt = ' + str(data_type)
 
 
 class NSUnknownNumber_SummaryProvider:

Modified: lldb/trunk/source/Core/CXXFormatterFunctions.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/CXXFormatterFunctions.cpp?rev=169751&r1=169750&r2=169751&view=diff
==============================================================================
--- lldb/trunk/source/Core/CXXFormatterFunctions.cpp (original)
+++ lldb/trunk/source/Core/CXXFormatterFunctions.cpp Mon Dec 10 13:23:00 2012
@@ -379,7 +379,7 @@
                     stream.Printf("(long)%" PRId64,value);
                     break;
                 default:
-                    stream.Printf("absurd value:(info=%" PRIu64 ", value=%" PRIu64,i_bits,value);
+                    stream.Printf("unexpected value:(info=%" PRIu64 ", value=%" PRIu64,i_bits,value);
                     break;
             }
             return true;





More information about the lldb-commits mailing list