[Lldb-commits] [lldb] r166959 - /lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp

Jim Ingham jingham at apple.com
Mon Oct 29 12:24:56 PDT 2012


Author: jingham
Date: Mon Oct 29 14:24:56 2012
New Revision: 166959

URL: http://llvm.org/viewvc/llvm-project?rev=166959&view=rev
Log:
Fix an incorrect comment...

Modified:
    lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp

Modified: lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp?rev=166959&r1=166958&r2=166959&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp (original)
+++ lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp Mon Oct 29 14:24:56 2012
@@ -1596,6 +1596,8 @@
                 // For now, just turn this off.
                 
                 // bool orig_is_resolver = (current_symbol->GetFlags() & MACH_O_N_SYMBOL_RESOLVER) == MACH_O_N_SYMBOL_RESOLVER;
+                // FIXME: Actually that isn't true, the N_SYMBOL_RESOLVER bit is only valid in .o files.  You can't use
+                // the symbol flags to tell whether something is a symbol resolver in a linked image.
                 bool orig_is_resolver = false;
                 
                 if (num_original_symbols > 0)





More information about the lldb-commits mailing list