[Lldb-commits] [lldb] r165852 - in /lldb/trunk: include/lldb/API/SBProcess.h scripts/Python/interface/SBProcess.i source/API/SBProcess.cpp

[Greg Clayton]

Author: gclayton
Date: Fri Oct 12 18:32:11 2012
New Revision: 165852

URL: http://llvm.org/viewvc/llvm-project?rev=165852&view=rev
Log:
<rdar://problem/12490558>

SBProcess::SetSelectedThreadByID() had a "uint32_t tid" parameter which would truncate 64 bit thread IDs (lldb::tid_t is 64 bit).

Modified:
    lldb/trunk/include/lldb/API/SBProcess.h
    lldb/trunk/scripts/Python/interface/SBProcess.i
    lldb/trunk/source/API/SBProcess.cpp

Modified: lldb/trunk/include/lldb/API/SBProcess.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/API/SBProcess.h?rev=165852&r1=165851&r2=165852&view=diff
==============================================================================
--- lldb/trunk/include/lldb/API/SBProcess.h (original)
+++ lldb/trunk/include/lldb/API/SBProcess.h Fri Oct 12 18:32:11 2012
@@ -116,7 +116,10 @@
     SetSelectedThread (const lldb::SBThread &thread);
 
     bool
-    SetSelectedThreadByID (uint32_t tid);
+    SetSelectedThreadByID (uint32_t tid); // DEPRECATED
+
+    bool
+    SetSelectedThreadByID (lldb::tid_t tid);
     
     bool
     SetSelectedThreadByIndexID (uint32_t index_id);

Modified: lldb/trunk/scripts/Python/interface/SBProcess.i
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/scripts/Python/interface/SBProcess.i?rev=165852&r1=165851&r2=165852&view=diff
==============================================================================
--- lldb/trunk/scripts/Python/interface/SBProcess.i (original)
+++ lldb/trunk/scripts/Python/interface/SBProcess.i Fri Oct 12 18:32:11 2012
@@ -158,7 +158,7 @@
     SetSelectedThread (const lldb::SBThread &thread);
 
     bool
-    SetSelectedThreadByID (uint32_t tid);
+    SetSelectedThreadByID (lldb::tid_t tid);
 
     bool
     SetSelectedThreadByIndexID (uint32_t index_id);

Modified: lldb/trunk/source/API/SBProcess.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/API/SBProcess.cpp?rev=165852&r1=165851&r2=165852&view=diff
==============================================================================
--- lldb/trunk/source/API/SBProcess.cpp (original)
+++ lldb/trunk/source/API/SBProcess.cpp Fri Oct 12 18:32:11 2012
@@ -398,6 +398,12 @@
 bool
 SBProcess::SetSelectedThreadByID (uint32_t tid)
 {
+    return SetSelectedThreadByID ((lldb::tid_t)tid);
+}
+
+bool
+SBProcess::SetSelectedThreadByID (lldb::tid_t tid)
+{
     LogSP log(lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_API));
 
     bool ret_val = false;
@@ -409,7 +415,7 @@
     }
 
     if (log)
-        log->Printf ("SBProcess(%p)::SetSelectedThreadByID (tid=0x%4.4x) => %s", 
+        log->Printf ("SBProcess(%p)::SetSelectedThreadByID (tid=0x%4.4llx) => %s", 
                      process_sp.get(), tid, (ret_val ? "true" : "false"));
 
     return ret_val;