[Lldb-commits] [lldb] r163282 - /lldb/trunk/source/Expression/ClangExpressionParser.cpp

Eric Christopher echristo at apple.com
Wed Sep 5 18:47:57 PDT 2012


On Sep 5, 2012, at 6:39 PM, Sean Callanan <scallanan at apple.com> wrote:

> Author: spyffe
> Date: Wed Sep  5 20:39:02 2012
> New Revision: 163282
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=163282&view=rev
> Log:
> Disable the "pretty stack trace" signal handler,
> which can conflict with accurate crash reporting
> in multithreaded contexts.
> 
> Modified:
>    lldb/trunk/source/Expression/ClangExpressionParser.cpp
> 
> Modified: lldb/trunk/source/Expression/ClangExpressionParser.cpp
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/ClangExpressionParser.cpp?rev=163282&r1=163281&r2=163282&view=diff
> ==============================================================================
> --- lldb/trunk/source/Expression/ClangExpressionParser.cpp (original)
> +++ lldb/trunk/source/Expression/ClangExpressionParser.cpp Wed Sep  5 20:39:02 2012
> @@ -195,6 +195,8 @@
>             llvm::InitializeAllAsmPrinters();
>             llvm::InitializeAllTargetMCs();
>             llvm::InitializeAllDisassemblers();
> +            
> +            llvm::DisablePrettyStackTrace = true;
>         }

For what it's worth since you were asking for a function earlier, it's not hard to encapsulate this into something that could be called. If nothing else getting rid of a global would be nice.

-eric




More information about the lldb-commits mailing list