[Lldb-commits] [lldb] r157631 - /lldb/trunk/source/API/SBFrame.cpp

Enrico Granata egranata at apple.com
Tue May 29 11:06:50 PDT 2012


Author: enrico
Date: Tue May 29 13:06:49 2012
New Revision: 157631

URL: http://llvm.org/viewvc/llvm-project?rev=157631&view=rev
Log:
rdar://problem/10996978 - Fixing an issue where crash reports for the expression parser might include symbols from the user's application

Modified:
    lldb/trunk/source/API/SBFrame.cpp

Modified: lldb/trunk/source/API/SBFrame.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/API/SBFrame.cpp?rev=157631&r1=157630&r2=157631&view=diff
==============================================================================
--- lldb/trunk/source/API/SBFrame.cpp (original)
+++ lldb/trunk/source/API/SBFrame.cpp Tue May 29 13:06:49 2012
@@ -1055,12 +1055,12 @@
         Process::StopLocker stop_locker;
         if (stop_locker.TryLock(&exe_ctx.GetProcessPtr()->GetRunLock()))
         {
+#ifdef LLDB_CONFIGURATION_DEBUG
             StreamString frame_description;
             frame->DumpUsingSettingsFormat (&frame_description);
-
             Host::SetCrashDescriptionWithFormat ("SBFrame::EvaluateExpression (expr = \"%s\", fetch_dynamic_value = %u) %s",
                                                  expr, fetch_dynamic_value, frame_description.GetString().c_str());
-
+#endif
             const bool coerce_to_id = false;
             const bool keep_in_memory = false;
 
@@ -1073,7 +1073,9 @@
                                                       fetch_dynamic_value, 
                                                       expr_value_sp);
             expr_result.SetSP(expr_value_sp);
+#ifdef LLDB_CONFIGURATION_DEBUG
             Host::SetCrashDescription (NULL);
+#endif
         }
         else
         {





More information about the lldb-commits mailing list