[Lldb-commits] test/lang/objc/objc-new-syntax/TestObjCNewSyntax.py and unexpected successes

[Johnny Chen]

Hi Sean,

152286     spyffe     def applies(self):
152286     spyffe         if platform.system() != "Darwin":
152286     spyffe             return False
152286     spyffe         if StrictVersion('12.0.0') > platform.release():
152286     spyffe             return False
152286     spyffe 
152286     spyffe         return True

Can you take a look at this?
Thanks.

On May 17, 2012, at 3:53 AM, Filipe Cabecinhas <filcab at gmail.com> wrote:

> Hi all, 
> 
> The test test/lang/objc/objc-new-syntax/TestObjCNewSyntax.py is an unexpected success on i386.
> It's marked as failing, but the only thing it does is immediately return.
> 
> When starting the test, this method is called:
>    def applies(self):
>      if platform.system() != "Darwin":
> 
> 
> 
> 
> 
> 
>        return False
>      if StrictVersion('12.0.0') > platform.release():
>        return False
>      return True
> 
> 
> 
> The problem is: platform.release(), on Lion, returns '11.4.0'. I don't know if this is an internal Apple test or if you're just waiting for lldb to make available the necessary methods for the new ObjC syntax and subscripting, since clang bails out with this, if we remove the previous check:
>    error: expected method to read array element not found on object of type 'NSArray *'
> 
> I suggest removing that check (or making it run on Lion) and marking the test as an expected failure on i386 and x86_64. That way, we know we have some work to do there. If we keep the test as is, then we should remove the expected failure annotation for i386, since the test is not failing (as far as the test suite is concerned).
> 
> Regards, 
> 
>  Filipe
> 
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits