[Lldb-commits] [lldb] r154711 - /lldb/trunk/source/API/SBFrame.cpp

[Jim Ingham]

Author: jingham
Date: Fri Apr 13 18:29:44 2012
New Revision: 154711

URL: http://llvm.org/viewvc/llvm-project?rev=154711&view=rev
Log:
The API lock was getting dropped too soon in GetVariables.  GetValueObjectForFrameVariable could run the target (to get dynamic values) and that requires the target lock.

Modified:
    lldb/trunk/source/API/SBFrame.cpp

Modified: lldb/trunk/source/API/SBFrame.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/API/SBFrame.cpp?rev=154711&r1=154710&r2=154711&view=diff
==============================================================================
--- lldb/trunk/source/API/SBFrame.cpp (original)
+++ lldb/trunk/source/API/SBFrame.cpp Fri Apr 13 18:29:44 2012
@@ -883,11 +883,8 @@
 
             size_t i;
             VariableList *variable_list = NULL;
-            // Scope for locker
-            {
-                Mutex::Locker api_locker (target->GetAPIMutex());
-                variable_list = frame->GetVariableList(true);
-            }
+            Mutex::Locker api_locker (target->GetAPIMutex());
+            variable_list = frame->GetVariableList(true);
             if (variable_list)
             {
                 const size_t num_variables = variable_list->GetSize();