[Lldb-commits] [lldb] r153712 - in /lldb/trunk/examples/summaries/cocoa: CFBag.py CFBinaryHeap.py CFBitVector.py CFDictionary.py NSBundle.py NSData.py NSDate.py NSException.py NSIndexSet.py NSMachPort.py NSNotification.py NSNumber.py NSSet.py NSURL.py

Enrico Granata egranata at apple.com
Thu Mar 29 17:51:14 PDT 2012 

Author: enrico
Date: Thu Mar 29 19:51:12 2012
New Revision: 153712

URL: http://llvm.org/viewvc/llvm-project?rev=153712&view=rev
Log:
Fixing a whole class of crashers and potential crashers related to data formatters eating up all the stack when an unknown class has to be summarized ; this should make the whole Objective-C summaries more stable

Modified:
    lldb/trunk/examples/summaries/cocoa/CFBag.py
    lldb/trunk/examples/summaries/cocoa/CFBinaryHeap.py
    lldb/trunk/examples/summaries/cocoa/CFBitVector.py
    lldb/trunk/examples/summaries/cocoa/CFDictionary.py
    lldb/trunk/examples/summaries/cocoa/NSBundle.py
    lldb/trunk/examples/summaries/cocoa/NSData.py
    lldb/trunk/examples/summaries/cocoa/NSDate.py
    lldb/trunk/examples/summaries/cocoa/NSException.py
    lldb/trunk/examples/summaries/cocoa/NSIndexSet.py
    lldb/trunk/examples/summaries/cocoa/NSMachPort.py
    lldb/trunk/examples/summaries/cocoa/NSNotification.py
    lldb/trunk/examples/summaries/cocoa/NSNumber.py
    lldb/trunk/examples/summaries/cocoa/NSSet.py
    lldb/trunk/examples/summaries/cocoa/NSURL.py

Modified: lldb/trunk/examples/summaries/cocoa/CFBag.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/examples/summaries/cocoa/CFBag.py?rev=153712&r1=153711&r2=153712&view=diff
==============================================================================
--- lldb/trunk/examples/summaries/cocoa/CFBag.py (original)
+++ lldb/trunk/examples/summaries/cocoa/CFBag.py Thu Mar 29 19:51:12 2012
@@ -96,7 +96,7 @@
 			statistics.metric_hit('code_notrun',valobj)
 			return wrapper
 	wrapper = CFBagUnknown_SummaryProvider(valobj, class_data.sys_params)
-	statistics.metric_hit('unknown_class',str(valobj) + " seen as " + actual_name)
+	statistics.metric_hit('unknown_class',valobj.GetName() + " seen as " + actual_name)
 	return wrapper;
 
 def CFBag_SummaryProvider (valobj,dict):

Modified: lldb/trunk/examples/summaries/cocoa/CFBinaryHeap.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/examples/summaries/cocoa/CFBinaryHeap.py?rev=153712&r1=153711&r2=153712&view=diff
==============================================================================
--- lldb/trunk/examples/summaries/cocoa/CFBinaryHeap.py (original)
+++ lldb/trunk/examples/summaries/cocoa/CFBinaryHeap.py Thu Mar 29 19:51:12 2012
@@ -92,7 +92,7 @@
 			statistics.metric_hit('code_notrun',valobj)
 			return wrapper
 	wrapper = CFBinaryHeapUnknown_SummaryProvider(valobj, class_data.sys_params)
-	statistics.metric_hit('unknown_class',str(valobj) + " seen as " + name_string)
+	statistics.metric_hit('unknown_class',valobj.GetName() + " seen as " + name_string)
 	return wrapper;
 
 def CFBinaryHeap_SummaryProvider (valobj,dict):

Modified: lldb/trunk/examples/summaries/cocoa/CFBitVector.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/examples/summaries/cocoa/CFBitVector.py?rev=153712&r1=153711&r2=153712&view=diff
==============================================================================
--- lldb/trunk/examples/summaries/cocoa/CFBitVector.py (original)
+++ lldb/trunk/examples/summaries/cocoa/CFBitVector.py Thu Mar 29 19:51:12 2012
@@ -136,7 +136,7 @@
 	else:
 		wrapper = CFBitVectorUnknown_SummaryProvider(valobj, class_data.sys_params)
 		print name_string
-		statistics.metric_hit('unknown_class',str(valobj) + " seen as " + name_string)
+		statistics.metric_hit('unknown_class',valobj.GetName() + " seen as " + name_string)
 	return wrapper;
 
 def CFBitVector_SummaryProvider (valobj,dict):

Modified: lldb/trunk/examples/summaries/cocoa/CFDictionary.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/examples/summaries/cocoa/CFDictionary.py?rev=153712&r1=153711&r2=153712&view=diff
==============================================================================
--- lldb/trunk/examples/summaries/cocoa/CFDictionary.py (original)
+++ lldb/trunk/examples/summaries/cocoa/CFDictionary.py Thu Mar 29 19:51:12 2012
@@ -165,7 +165,7 @@
 		statistics.metric_hit('code_notrun',valobj)
 	else:
 		wrapper = NSDictionaryUnknown_SummaryProvider(valobj, class_data.sys_params)
-		statistics.metric_hit('unknown_class',str(valobj) + " seen as " + name_string)
+		statistics.metric_hit('unknown_class',valobj.GetName() + " seen as " + name_string)
 	return wrapper;
 
 def CFDictionary_SummaryProvider (valobj,dict):

Modified: lldb/trunk/examples/summaries/cocoa/NSBundle.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/examples/summaries/cocoa/NSBundle.py?rev=153712&r1=153711&r2=153712&view=diff
==============================================================================
--- lldb/trunk/examples/summaries/cocoa/NSBundle.py (original)
+++ lldb/trunk/examples/summaries/cocoa/NSBundle.py Thu Mar 29 19:51:12 2012
@@ -92,7 +92,7 @@
 		#statistics.metric_hit('code_notrun',valobj)
 	else:
 		wrapper = NSBundleUnknown_SummaryProvider(valobj, class_data.sys_params)
-		statistics.metric_hit('unknown_class',str(valobj) + " seen as " + name_string)
+		statistics.metric_hit('unknown_class',valobj.GetName() + " seen as " + name_string)
 	return wrapper;
 
 def NSBundle_SummaryProvider (valobj,dict):

Modified: lldb/trunk/examples/summaries/cocoa/NSData.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/examples/summaries/cocoa/NSData.py?rev=153712&r1=153711&r2=153712&view=diff
==============================================================================
--- lldb/trunk/examples/summaries/cocoa/NSData.py (original)
+++ lldb/trunk/examples/summaries/cocoa/NSData.py Thu Mar 29 19:51:12 2012
@@ -106,7 +106,7 @@
 		statistics.metric_hit('code_notrun',valobj)
 	else:
 		wrapper = NSDataUnknown_SummaryProvider(valobj, class_data.sys_params)
-		statistics.metric_hit('unknown_class',str(valobj) + " seen as " + name_string)
+		statistics.metric_hit('unknown_class',valobj.GetName() + " seen as " + name_string)
 	return wrapper;
 
 def NSData_SummaryProvider (valobj,dict):

Modified: lldb/trunk/examples/summaries/cocoa/NSDate.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/examples/summaries/cocoa/NSDate.py?rev=153712&r1=153711&r2=153712&view=diff
==============================================================================
--- lldb/trunk/examples/summaries/cocoa/NSDate.py (original)
+++ lldb/trunk/examples/summaries/cocoa/NSDate.py Thu Mar 29 19:51:12 2012
@@ -186,7 +186,7 @@
 		statistics.metric_hit('code_notrun',valobj)
 	else:
 		wrapper = NSUnknownDate_SummaryProvider(valobj, class_data.sys_params)
-		statistics.metric_hit('unknown_class',str(valobj) + " seen as " + name_string)
+		statistics.metric_hit('unknown_class',valobj.GetName() + " seen as " + name_string)
 	return wrapper;
 
 

Modified: lldb/trunk/examples/summaries/cocoa/NSException.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/examples/summaries/cocoa/NSException.py?rev=153712&r1=153711&r2=153712&view=diff
==============================================================================
--- lldb/trunk/examples/summaries/cocoa/NSException.py (original)
+++ lldb/trunk/examples/summaries/cocoa/NSException.py Thu Mar 29 19:51:12 2012
@@ -79,7 +79,7 @@
 		statistics.metric_hit('code_notrun',valobj)
 	else:
 		wrapper = NSUnknownException_SummaryProvider(valobj, class_data.sys_params)
-		statistics.metric_hit('unknown_class',str(valobj) + " seen as " + name_string)
+		statistics.metric_hit('unknown_class',valobj.GetName() + " seen as " + name_string)
 	return wrapper;
 
 def NSException_SummaryProvider (valobj,dict):

Modified: lldb/trunk/examples/summaries/cocoa/NSIndexSet.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/examples/summaries/cocoa/NSIndexSet.py?rev=153712&r1=153711&r2=153712&view=diff
==============================================================================
--- lldb/trunk/examples/summaries/cocoa/NSIndexSet.py (original)
+++ lldb/trunk/examples/summaries/cocoa/NSIndexSet.py Thu Mar 29 19:51:12 2012
@@ -103,7 +103,7 @@
 		statistics.metric_hit('code_notrun',valobj)
 	else:
 		wrapper = NSIndexSetUnknown_SummaryProvider(valobj, class_data.sys_params)
-		statistics.metric_hit('unknown_class',str(valobj) + " seen as " + name_string)
+		statistics.metric_hit('unknown_class',valobj.GetName() + " seen as " + name_string)
 	return wrapper;
 
 

Modified: lldb/trunk/examples/summaries/cocoa/NSMachPort.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/examples/summaries/cocoa/NSMachPort.py?rev=153712&r1=153711&r2=153712&view=diff
==============================================================================
--- lldb/trunk/examples/summaries/cocoa/NSMachPort.py (original)
+++ lldb/trunk/examples/summaries/cocoa/NSMachPort.py Thu Mar 29 19:51:12 2012
@@ -86,7 +86,7 @@
 		statistics.metric_hit('code_notrun',valobj)
 	else:
 		wrapper = NSMachPortUnknown_SummaryProvider(valobj, class_data.sys_params)
-		statistics.metric_hit('unknown_class',str(valobj) + " seen as " + name_string)
+		statistics.metric_hit('unknown_class',valobj.GetName() + " seen as " + name_string)
 	return wrapper;
 
 def NSMachPort_SummaryProvider (valobj,dict):

Modified: lldb/trunk/examples/summaries/cocoa/NSNotification.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/examples/summaries/cocoa/NSNotification.py?rev=153712&r1=153711&r2=153712&view=diff
==============================================================================
--- lldb/trunk/examples/summaries/cocoa/NSNotification.py (original)
+++ lldb/trunk/examples/summaries/cocoa/NSNotification.py Thu Mar 29 19:51:12 2012
@@ -75,7 +75,7 @@
 		statistics.metric_hit('code_notrun',valobj)
 	else:
 		wrapper = NSNotificationUnknown_SummaryProvider(valobj, class_data.sys_params)
-		statistics.metric_hit('unknown_class',str(valobj) + " seen as " + name_string)
+		statistics.metric_hit('unknown_class',valobj.GetName() + " seen as " + name_string)
 	return wrapper;
 
 def NSNotification_SummaryProvider (valobj,dict):

Modified: lldb/trunk/examples/summaries/cocoa/NSNumber.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/examples/summaries/cocoa/NSNumber.py?rev=153712&r1=153711&r2=153712&view=diff
==============================================================================
--- lldb/trunk/examples/summaries/cocoa/NSNumber.py (original)
+++ lldb/trunk/examples/summaries/cocoa/NSNumber.py Thu Mar 29 19:51:12 2012
@@ -191,7 +191,7 @@
 			wrapper = NSUntaggedNumber_SummaryProvider(valobj, class_data.sys_params)
 	else:
 		wrapper = NSUnknownNumber_SummaryProvider(valobj, class_data.sys_params)
-		statistics.metric_hit('unknown_class',str(valobj) + " seen as " + name_string)
+		statistics.metric_hit('unknown_class',valobj.GetName() + " seen as " + name_string)
 	return wrapper;
 
 

Modified: lldb/trunk/examples/summaries/cocoa/NSSet.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/examples/summaries/cocoa/NSSet.py?rev=153712&r1=153711&r2=153712&view=diff
==============================================================================
--- lldb/trunk/examples/summaries/cocoa/NSSet.py (original)
+++ lldb/trunk/examples/summaries/cocoa/NSSet.py Thu Mar 29 19:51:12 2012
@@ -186,7 +186,7 @@
 		statistics.metric_hit('code_notrun',valobj)
 	else:
 		wrapper = NSSetUnknown_SummaryProvider(valobj, class_data.sys_params)
-		statistics.metric_hit('unknown_class',str(valobj) + " seen as " + name_string)
+		statistics.metric_hit('unknown_class',valobj.GetName() + " seen as " + name_string)
 	return wrapper;
 
 

Modified: lldb/trunk/examples/summaries/cocoa/NSURL.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/examples/summaries/cocoa/NSURL.py?rev=153712&r1=153711&r2=153712&view=diff
==============================================================================
--- lldb/trunk/examples/summaries/cocoa/NSURL.py (original)
+++ lldb/trunk/examples/summaries/cocoa/NSURL.py Thu Mar 29 19:51:12 2012
@@ -99,7 +99,7 @@
 		statistics.metric_hit('code_notrun',valobj)
 	else:
 		wrapper = NSURLUnknown_SummaryProvider(valobj, class_data.sys_params)
-		statistics.metric_hit('unknown_class',str(valobj) + " seen as " + name_string)
+		statistics.metric_hit('unknown_class',valobj.GetName() + " seen as " + name_string)
 	return wrapper;
 
 def NSURL_SummaryProvider (valobj,dict):

More information about the lldb-commits mailing list