[Lldb-commits] [lldb] r152267 - in /lldb/trunk: include/lldb/API/SBTarget.h source/API/SBTarget.cpp

Greg Clayton gclayton at apple.com
Wed Mar 7 15:52:51 PST 2012


Author: gclayton
Date: Wed Mar  7 17:52:51 2012
New Revision: 152267

URL: http://llvm.org/viewvc/llvm-project?rev=152267&view=rev
Log:
Moved inline functions into SBTarget.cpp and made destructors for SBLaunchInfo and SBAttachInfo to avoid link warnings.


Modified:
    lldb/trunk/include/lldb/API/SBTarget.h
    lldb/trunk/source/API/SBTarget.cpp

Modified: lldb/trunk/include/lldb/API/SBTarget.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/API/SBTarget.h?rev=152267&r1=152266&r2=152267&view=diff
==============================================================================
--- lldb/trunk/include/lldb/API/SBTarget.h (original)
+++ lldb/trunk/include/lldb/API/SBTarget.h Wed Mar  7 17:52:51 2012
@@ -25,6 +25,8 @@
 public:
     SBLaunchInfo (const char **argv);
     
+    ~SBLaunchInfo();
+
     uint32_t
     GetUserID();
     
@@ -110,10 +112,7 @@
     friend class SBTarget;
     
     lldb_private::ProcessLaunchInfo &
-    ref ()
-    {
-        return *m_opaque_sp;
-    }
+    ref ();
 
     ProcessLaunchInfoSP m_opaque_sp;
 };
@@ -129,6 +128,8 @@
     
     SBAttachInfo (const SBAttachInfo &rhs);
     
+    ~SBAttachInfo();
+
     SBAttachInfo &
     operator = (const SBAttachInfo &rhs);
     
@@ -212,10 +213,7 @@
     friend class SBTarget;
 
     lldb_private::ProcessAttachInfo &
-    ref ()
-    {
-        return *m_opaque_sp;
-    }
+    ref ();
     
     ProcessAttachInfoSP m_opaque_sp;
 };

Modified: lldb/trunk/source/API/SBTarget.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/API/SBTarget.cpp?rev=152267&r1=152266&r2=152267&view=diff
==============================================================================
--- lldb/trunk/source/API/SBTarget.cpp (original)
+++ lldb/trunk/source/API/SBTarget.cpp Wed Mar  7 17:52:51 2012
@@ -63,6 +63,17 @@
         m_opaque_sp->GetArguments().SetArguments(argv);
 }
 
+SBLaunchInfo::~SBLaunchInfo()
+{
+}
+
+lldb_private::ProcessLaunchInfo &
+SBLaunchInfo::ref ()
+{
+    return *m_opaque_sp;
+}
+
+
 uint32_t
 SBLaunchInfo::GetUserID()
 {
@@ -249,18 +260,18 @@
 
 
 SBAttachInfo::SBAttachInfo () :
-m_opaque_sp (new ProcessAttachInfo())
+    m_opaque_sp (new ProcessAttachInfo())
 {
 }
 
 SBAttachInfo::SBAttachInfo (lldb::pid_t pid) :
-m_opaque_sp (new ProcessAttachInfo())
+    m_opaque_sp (new ProcessAttachInfo())
 {
     m_opaque_sp->SetProcessID (pid);
 }
 
 SBAttachInfo::SBAttachInfo (const char *path, bool wait_for) :
-m_opaque_sp (new ProcessAttachInfo())
+    m_opaque_sp (new ProcessAttachInfo())
 {
     if (path && path[0])
         m_opaque_sp->GetExecutableFile().SetFile(path, false);
@@ -268,11 +279,21 @@
 }
 
 SBAttachInfo::SBAttachInfo (const SBAttachInfo &rhs) :
-m_opaque_sp (new ProcessAttachInfo())
+    m_opaque_sp (new ProcessAttachInfo())
 {
     *m_opaque_sp = *rhs.m_opaque_sp;
 }
 
+SBAttachInfo::~SBAttachInfo()
+{
+}
+
+lldb_private::ProcessAttachInfo &
+SBAttachInfo::ref ()
+{
+    return *m_opaque_sp;
+}
+
 SBAttachInfo &
 SBAttachInfo::operator = (const SBAttachInfo &rhs)
 {





More information about the lldb-commits mailing list