[Lldb-commits] [lldb] r147790 - in /lldb/trunk: include/lldb/Target/ABI.h source/Plugins/ABI/MacOSX-arm/ABIMacOSX_arm.h

Greg Clayton gclayton at apple.com
Mon Jan 9 11:23:34 PST 2012


Author: gclayton
Date: Mon Jan  9 13:23:34 2012
New Revision: 147790

URL: http://llvm.org/viewvc/llvm-project?rev=147790&view=rev
Log:
Fixed a return value problem with the new ABI::FixCodeAddress () function:

it was checked in as:
 virtual bool ABI::FixCodeAddress (lldb::addr_t pc);

when it should have been:

virtual lldb::addr_t ABI::FixCodeAddress (lldb::addr_t pc);


 

Modified:
    lldb/trunk/include/lldb/Target/ABI.h
    lldb/trunk/source/Plugins/ABI/MacOSX-arm/ABIMacOSX_arm.h

Modified: lldb/trunk/include/lldb/Target/ABI.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Target/ABI.h?rev=147790&r1=147789&r2=147790&view=diff
==============================================================================
--- lldb/trunk/include/lldb/Target/ABI.h (original)
+++ lldb/trunk/include/lldb/Target/ABI.h Mon Jan  9 13:23:34 2012
@@ -76,7 +76,7 @@
     virtual bool
     CodeAddressIsValid (lldb::addr_t pc) = 0;    
 
-    virtual bool
+    virtual lldb::addr_t
     FixCodeAddress (lldb::addr_t pc)
     {
         // Some targets might use bits in a code address to indicate

Modified: lldb/trunk/source/Plugins/ABI/MacOSX-arm/ABIMacOSX_arm.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ABI/MacOSX-arm/ABIMacOSX_arm.h?rev=147790&r1=147789&r2=147790&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ABI/MacOSX-arm/ABIMacOSX_arm.h (original)
+++ lldb/trunk/source/Plugins/ABI/MacOSX-arm/ABIMacOSX_arm.h Mon Jan  9 13:23:34 2012
@@ -82,7 +82,7 @@
         return pc <= UINT32_MAX;
     }
     
-    virtual bool
+    virtual lldb::addr_t
     FixCodeAddress (lldb::addr_t pc)
     {
         // ARM uses bit zero to signify a code address is thumb, so we must





More information about the lldb-commits mailing list