[Lldb-commits] [lldb] r144562 - in /lldb/trunk: lldb.xcodeproj/project.pbxproj source/Interpreter/CommandInterpreter.cpp

[Chris Lattner]

On Nov 14, 2011, at 12:02 PM, Jim Ingham wrote:
> URL: http://llvm.org/viewvc/llvm-project?rev=144562&view=rev
> Log:
> Confirm should accept both "Y" and "y" in case somebody confuses the "default answer" indicator for a
> directive to enter a capital letter.

Thanks Jim,

> +++ lldb/trunk/lldb.xcodeproj/project.pbxproj Mon Nov 14 14:02:01 2011
> @@ -3621,7 +3621,7 @@
> 				GCC_WARN_UNUSED_VARIABLE = YES;
> 				LLVM_BUILD_DIR = "$(SRCROOT)/llvm-build/$(LLVM_CONFIGURATION)";
> 				LLVM_BUILD_DIR_ARCH = "$(CURRENT_ARCH)/";
> -				LLVM_CONFIGURATION = Release;
> +				LLVM_CONFIGURATION = "Debug+Asserts";

Was this intentional?

> @@ -1807,7 +1807,7 @@
>         {
>             if (out_file.IsValid() && !reader.IsDone() && reader.GetPrompt())
>             {
> -                out_file.Printf ("Please answer \"y\" or \"n\"\n%s", reader.GetPrompt());
> +                out_file.Printf ("Please answer \"y\" or \"Y\" or \"n\" or \"N\"\n%s", reader.GetPrompt());
>                 out_file.Flush ();
>             }

There is no need to be exhaustive here, just ask for y/n and accept both cases.

-Chris