[Lldb-commits] [lldb] r138046 - /lldb/trunk/source/Plugins/Disassembler/llvm/DisassemblerLLVM.cpp

Johnny Chen johnny.chen at apple.com
Fri Aug 19 10:31:59 PDT 2011


Author: johnny
Date: Fri Aug 19 12:31:59 2011
New Revision: 138046

URL: http://llvm.org/viewvc/llvm-project?rev=138046&view=rev
Log:
Revert the workaround patch in the last check in.  With the local patch to LLVM, it is no longer necessary.

Modified:
    lldb/trunk/source/Plugins/Disassembler/llvm/DisassemblerLLVM.cpp

Modified: lldb/trunk/source/Plugins/Disassembler/llvm/DisassemblerLLVM.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Disassembler/llvm/DisassemblerLLVM.cpp?rev=138046&r1=138045&r2=138046&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Disassembler/llvm/DisassemblerLLVM.cpp (original)
+++ lldb/trunk/source/Plugins/Disassembler/llvm/DisassemblerLLVM.cpp Fri Aug 19 12:31:59 2011
@@ -132,13 +132,6 @@
     if (!Str.empty() && Str.back() == c)
         Str = Str.substr(0, Str.size()-1);
 }
-static inline void RStripNumber(llvm::StringRef &Str)
-{
-    while (!Str.empty() && isnumber(Str.back()))
-        Str = Str.substr(0, Str.size()-1);
-    if (!Str.empty() && Str.back() == '-')
-        Str = Str.substr(0, Str.size()-1);
-}
 // Aligns the raw disassembly (passed as 'str') with the rest of edis'ed disassembly output.
 // This is called from non-raw mode when edis of the current m_inst fails for some reason.
 static void
@@ -153,19 +146,6 @@
         PadString(s, p.second, operandColWidth);
 }
 
-static bool
-apply_workaround(const char *str)
-{
-  llvm::StringRef Str(str);
-  StripSpaces(Str);
-  if (Str.startswith("mov.w")) {
-      RStripNumber(Str);
-      if (Str.endswith("#"))
-          return true;
-  }
-  return false;
-}
-
 #define AlignPC(pc_val) (pc_val & 0xFFFFFFFC)
 void
 InstructionLLVM::Dump
@@ -232,16 +212,7 @@
     */
     /* .... when we fix the edis for arm/thumb. */
 
-    const char *lookahead;
-    bool workaround = false;
-    if (EDGetInstString(&lookahead, m_inst)) // 0 on success
-      return;
-    else if (m_arch_type == llvm::Triple::thumb) {
-        if (apply_workaround(lookahead))
-            workaround = true;
-    }
-
-    if (!raw && !workaround)
+    if (!raw)
         numTokens = EDNumTokens(m_inst);
 
     int currentOpIndex = -1;





More information about the lldb-commits mailing list