[Lldb-commits] [lldb] r124892 - in /lldb/trunk: include/lldb/Host/Config.h include/lldb/Host/freebsd/ include/lldb/Host/freebsd/Config.h include/lldb/Host/linux/ include/lldb/Host/linux/Config.h include/lldb/Host/macosx/ include/lldb/Host/macosx/Config.h include/lldb/Host/mingw/ include/lldb/Host/mingw/Config.h lldb.xcodeproj/project.pbxproj

[Stephen Wilson]

Hi Greg,

Greg Clayton <gclayton at apple.com> writes:
> Added the start of platform configuration designed for internal LLDB use. 
> Internal use means for compiling the LLDB debug engine and plug-ins, but it
> should never make it into the public API.

This is great!

> Since we don't currently have a configuration script that detects avaiable
> functionality in the LLDB build system, we are hard coding #define values
> in the host specific "Config.h" files. 
>
> #define values in these Config.h header files should set the value to zero or
> one:
>
> #define LLDB_CONFIG_TERMIOS_SUPPORTED 1
>
> #define LLDB_CONFIG_OTHER 0

Hmmm.  This goes against the well established practice of #define'ing
things IFF they are available:


#if defined(HAVE_TERMIOS)
   ...
#else
   ...
#endif


It would be great to have a configure script available for LLDB.
Adhering to the established practice would make things much easier if we
were to generate a configure script and config.h headers using tools
like autoconf.


--
steve