[Lldb-commits] [lldb] r123816 - in /lldb/trunk/include/lldb/Target: ThreadPlanCallFunction.h ThreadPlanCallUserExpression.h

Jim Ingham jingham at apple.com
Wed Jan 19 01:45:44 PST 2011


Author: jingham
Date: Wed Jan 19 03:45:44 2011
New Revision: 123816

URL: http://llvm.org/viewvc/llvm-project?rev=123816&view=rev
Log:
ThreadPlanCallUserExpression's WillPop needs to call it's parent's WillPop.

Modified:
    lldb/trunk/include/lldb/Target/ThreadPlanCallFunction.h
    lldb/trunk/include/lldb/Target/ThreadPlanCallUserExpression.h

Modified: lldb/trunk/include/lldb/Target/ThreadPlanCallFunction.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Target/ThreadPlanCallFunction.h?rev=123816&r1=123815&r2=123816&view=diff
==============================================================================
--- lldb/trunk/include/lldb/Target/ThreadPlanCallFunction.h (original)
+++ lldb/trunk/include/lldb/Target/ThreadPlanCallFunction.h Wed Jan 19 03:45:44 2011
@@ -70,6 +70,9 @@
         return true;
     }
     
+    // Classes that derive from ClangFunction, and implement
+    // their own WillPop methods should call this so that the
+    // thread state gets restored if the plan gets discarded.
     virtual void
     WillPop ();
 

Modified: lldb/trunk/include/lldb/Target/ThreadPlanCallUserExpression.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Target/ThreadPlanCallUserExpression.h?rev=123816&r1=123815&r2=123816&view=diff
==============================================================================
--- lldb/trunk/include/lldb/Target/ThreadPlanCallUserExpression.h (original)
+++ lldb/trunk/include/lldb/Target/ThreadPlanCallUserExpression.h Wed Jan 19 03:45:44 2011
@@ -43,6 +43,7 @@
     virtual void
     WillPop ()
     {
+        ThreadPlanCallFunction::WillPop();
         if (m_user_expression_sp)
             m_user_expression_sp.reset();
     }





More information about the lldb-commits mailing list