[Lldb-commits] [PATCH 8/8] Add empty implementation of pure virtual RegisterContext::InvalidateAllRegisters.

[Stephen Wilson]

Greg Clayton <gclayton at apple.com> writes:

> Here is where you will want to track if you have read your regiters
> from what ever you read registers from on Linux.

OK.

> You might to just want to copy the
> "lldb/source/Plugins/Process/MacOSX-User/source/RegisterContextMach_x86_64.cpp"
> and
> "lldb/source/Plugins/Process/MacOSX-User/source/RegisterContextMach_x86_64.h"
> files and modify the structures to match linux. This has all of the
> invalidating code done on a per/register group basis (gpr, fpu and exc
> registers).

Absolutely.  Is it OK for this patch to go in as is?  Since the method
is pure virtual this empty implementation simply allows the tree to
build.  I will certainly look into implementing the method properly in
the near future.


>
> On Jan 14, 2011, at 1:12 PM, Stephen Wilson wrote:
>
>> ---
>> .../Process/Linux/RegisterContextLinux_x86_64.cpp  |    5 +++++
>> .../Process/Linux/RegisterContextLinux_x86_64.h    |    3 +++
>> 2 files changed, 8 insertions(+), 0 deletions(-)
>> 
>> diff --git a/source/Plugins/Process/Linux/RegisterContextLinux_x86_64.cpp b/source/Plugins/Process/Linux/RegisterContextLinux_x86_64.cpp
>> index da6ea8d..27cd6c6 100644
>> --- a/source/Plugins/Process/Linux/RegisterContextLinux_x86_64.cpp
>> +++ b/source/Plugins/Process/Linux/RegisterContextLinux_x86_64.cpp
>> @@ -423,6 +423,11 @@ RegisterContextLinux_x86_64::Invalidate()
>> {
>> }
>> 
>> +void
>> +RegisterContextLinux_x86_64::InvalidateAllRegisters()
>> +{
>> +}
>> +
>> size_t
>> RegisterContextLinux_x86_64::GetRegisterCount()
>> {
>> diff --git a/source/Plugins/Process/Linux/RegisterContextLinux_x86_64.h b/source/Plugins/Process/Linux/RegisterContextLinux_x86_64.h
>> index dc421ec..876d685 100644
>> --- a/source/Plugins/Process/Linux/RegisterContextLinux_x86_64.h
>> +++ b/source/Plugins/Process/Linux/RegisterContextLinux_x86_64.h
>> @@ -26,6 +26,9 @@ public:
>>     void
>>     Invalidate();
>> 
>> +    void
>> +    InvalidateAllRegisters();
>> +
>>     size_t
>>     GetRegisterCount();
>> 
>> -- 
>> 1.7.3.5
>> 
>> _______________________________________________
>> lldb-commits mailing list
>> lldb-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>



--
steve