[Lldb-commits] [PATCH 3/3] Rearrange #include's, initialization/termination.

Stephen Wilson wilsons at start.ca
Fri Dec 17 10:41:44 PST 2010


Greg Clayton <gclayton at apple.com> writes:
> I have removed "lldb/trunk/source/Plugins/Process/Utility/libunwind"
> and all the tentacles that it had left behind as, after we switched to
> our new unwinder, we no longer used any of the libunwind sources. This
> should help keep the needed files down to a minimum and ease your
> linux porting changes!
>
> Let me know how these latest changes work for you,

This is fantastic!  Everything in the Process/Utility directory compiles
just fine for me now.

Thanks!

> Greg Clayton
>
>
>
> Author: gclayton
> Date: Fri Dec 17 09:50:20 2010
> New Revision: 122059
>
> URL: http://llvm.org/viewvc/llvm-project?rev=122059&view=rev
> Log:
> Removed libunwind sources as we aren't using them anymore.
>
>
> Removed:
>    lldb/trunk/source/Plugins/Process/Utility/LibUnwindRegisterContext.cpp
>    lldb/trunk/source/Plugins/Process/Utility/LibUnwindRegisterContext.h
>    lldb/trunk/source/Plugins/Process/Utility/MacOSXLibunwindCallbacks.cpp
>    lldb/trunk/source/Plugins/Process/Utility/MacOSXLibunwindCallbacks.h
>    lldb/trunk/source/Plugins/Process/Utility/UnwindLibUnwind.cpp
>    lldb/trunk/source/Plugins/Process/Utility/UnwindLibUnwind.h
>    lldb/trunk/source/Plugins/Process/Utility/libunwind/
> Modified:
>    lldb/trunk/include/lldb/Target/Thread.h
>    lldb/trunk/lldb.xcodeproj/project.pbxproj
>    lldb/trunk/source/Plugins/Process/MacOSX-User/source/ThreadMacOSX.cpp
>    lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
>    lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
>    lldb/trunk/source/Plugins/Process/gdb-remote/ThreadGDBRemote.cpp
>    lldb/trunk/source/Plugins/Process/gdb-remote/ThreadGDBRemote.h
> On Dec 16, 2010, at 10:31 PM, Stephen Wilson wrote:
>
>> 
>> Hi Greg,
>> 
>> Stephen Wilson <wilsons at start.ca> writes:
>>> The only remaining problem is how to get the Makefiles working for this
>>> directory.  I will take a closer look at the LLVM Makefiles, but I do
>>> not remember seeing a way to exclude files within a directory from the
>>> build.
>>> 
>>> Would it be unreasonable to split up Process/Utility with a few more
>>> logical subdirectories in which we place platform-specific components if
>>> it turns out the current Makefile system cannot be pushed into dealing
>>> with the layout as is?
>> 
>> I have a solution for the Makefiles.  Will push the patch out along with
>> some of the other Makefile changes shortly.
>> 
>> Take care,
>> 
>> --
>> steve
>

--
steve



More information about the lldb-commits mailing list