[Lldb-commits] [lldb] r114771 - in /lldb/trunk: include/lldb/Expression/ClangFunction.h include/lldb/Expression/ClangUserExpression.h include/lldb/Expression/ClangUtilityFunction.h include/lldb/Utility/SharingPtr.h include/lldb/lldb-types.h source/Expression/ClangUtilityFunction.cpp source/Utility/SharingPtr.cpp

[Greg Clayton]

Author: gclayton
Date: Fri Sep 24 18:07:41 2010
New Revision: 114771

URL: http://llvm.org/viewvc/llvm-project?rev=114771&view=rev
Log:
Cleaned a few build related things up:

Added a virtual destructor to ClangUtilityFunction with a body to it cleans
itself up.

Moved our SharingPtr into the lldb_private namespace to keep it easy to make
an exports file that exports only what is needed ("lldb::*").


Modified:
    lldb/trunk/include/lldb/Expression/ClangFunction.h
    lldb/trunk/include/lldb/Expression/ClangUserExpression.h
    lldb/trunk/include/lldb/Expression/ClangUtilityFunction.h
    lldb/trunk/include/lldb/Utility/SharingPtr.h
    lldb/trunk/include/lldb/lldb-types.h
    lldb/trunk/source/Expression/ClangUtilityFunction.cpp
    lldb/trunk/source/Utility/SharingPtr.cpp

Modified: lldb/trunk/include/lldb/Expression/ClangFunction.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Expression/ClangFunction.h?rev=114771&r1=114770&r2=114771&view=diff
==============================================================================
--- lldb/trunk/include/lldb/Expression/ClangFunction.h (original)
+++ lldb/trunk/include/lldb/Expression/ClangFunction.h Fri Sep 24 18:07:41 2010
@@ -130,7 +130,8 @@
     //------------------------------------------------------------------
 	/// Destructor
 	//------------------------------------------------------------------
-	virtual ~ClangFunction();
+	virtual 
+    ~ClangFunction();
 
     //------------------------------------------------------------------
 	/// Compile the wrapper function

Modified: lldb/trunk/include/lldb/Expression/ClangUserExpression.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Expression/ClangUserExpression.h?rev=114771&r1=114770&r2=114771&view=diff
==============================================================================
--- lldb/trunk/include/lldb/Expression/ClangUserExpression.h (original)
+++ lldb/trunk/include/lldb/Expression/ClangUserExpression.h Fri Sep 24 18:07:41 2010
@@ -50,7 +50,8 @@
     //------------------------------------------------------------------
     /// Destructor
     //------------------------------------------------------------------
-    virtual ~ClangUserExpression ();
+    virtual 
+    ~ClangUserExpression ();
     
     //------------------------------------------------------------------
     /// Parse the expression

Modified: lldb/trunk/include/lldb/Expression/ClangUtilityFunction.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Expression/ClangUtilityFunction.h?rev=114771&r1=114770&r2=114771&view=diff
==============================================================================
--- lldb/trunk/include/lldb/Expression/ClangUtilityFunction.h (original)
+++ lldb/trunk/include/lldb/Expression/ClangUtilityFunction.h Fri Sep 24 18:07:41 2010
@@ -52,6 +52,9 @@
     ClangUtilityFunction (const char *text, 
                           const char *name);
     
+    virtual 
+    ~ClangUtilityFunction ();
+
     //------------------------------------------------------------------
     /// Install the utility function into a process
     ///

Modified: lldb/trunk/include/lldb/Utility/SharingPtr.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Utility/SharingPtr.h?rev=114771&r1=114770&r2=114771&view=diff
==============================================================================
--- lldb/trunk/include/lldb/Utility/SharingPtr.h (original)
+++ lldb/trunk/include/lldb/Utility/SharingPtr.h Fri Sep 24 18:07:41 2010
@@ -13,7 +13,7 @@
 #include <algorithm>
 #include <memory>
 
-namespace lldb {
+namespace lldb_private {
 
 namespace imp {
 

Modified: lldb/trunk/include/lldb/lldb-types.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/lldb-types.h?rev=114771&r1=114770&r2=114771&view=diff
==============================================================================
--- lldb/trunk/include/lldb/lldb-types.h (original)
+++ lldb/trunk/include/lldb/lldb-types.h Fri Sep 24 18:07:41 2010
@@ -67,7 +67,7 @@
         template<typename _Tp>
         struct SharedPtr
         {
-            typedef lldb::SharingPtr<_Tp> Type;
+            typedef lldb_private::SharingPtr<_Tp> Type;
         };
 
 } // namespace lldb

Modified: lldb/trunk/source/Expression/ClangUtilityFunction.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/ClangUtilityFunction.cpp?rev=114771&r1=114770&r2=114771&view=diff
==============================================================================
--- lldb/trunk/source/Expression/ClangUtilityFunction.cpp (original)
+++ lldb/trunk/source/Expression/ClangUtilityFunction.cpp Fri Sep 24 18:07:41 2010
@@ -44,6 +44,10 @@
 {
 }
 
+ClangUtilityFunction::~ClangUtilityFunction ()
+{
+}
+
 //------------------------------------------------------------------
 /// Install the utility function into a process
 ///

Modified: lldb/trunk/source/Utility/SharingPtr.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Utility/SharingPtr.cpp?rev=114771&r1=114770&r2=114771&view=diff
==============================================================================
--- lldb/trunk/source/Utility/SharingPtr.cpp (original)
+++ lldb/trunk/source/Utility/SharingPtr.cpp Fri Sep 24 18:07:41 2010
@@ -9,7 +9,7 @@
 
 #include "lldb/Utility/SharingPtr.h"
 
-namespace lldb {
+namespace lldb_private {
 
 namespace imp
 {