[Lldb-commits] [lldb] r113037 - in /lldb/trunk/test: lldbtest.py macosx/universal/TestUniversal.py plugins/darwin.py

[Johnny Chen]

Author: johnny
Date: Fri Sep  3 18:49:16 2010
New Revision: 113037

URL: http://llvm.org/viewvc/llvm-project?rev=113037&view=rev
Log:
Marked test_process_launch_for_universal() test case as requiring 'darwin' and 'i386'
in order to be run.  And added a default build phase at the beginning of the method.

Modified:
    lldb/trunk/test/lldbtest.py
    lldb/trunk/test/macosx/universal/TestUniversal.py
    lldb/trunk/test/plugins/darwin.py

Modified: lldb/trunk/test/lldbtest.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/lldbtest.py?rev=113037&r1=113036&r2=113037&view=diff
==============================================================================
--- lldb/trunk/test/lldbtest.py (original)
+++ lldb/trunk/test/lldbtest.py Fri Sep  3 18:49:16 2010
@@ -458,6 +458,12 @@
             # End of while loop.
 
 
+    def buildDefault(self):
+        """Platform specific way to build the default binaries."""
+        module = __import__(sys.platform)
+        if not module.buildDefault():
+            raise Exception("Don't know how to build default binary")
+
     def buildDsym(self):
         """Platform specific way to build binaries with dsym info."""
         module = __import__(sys.platform)

Modified: lldb/trunk/test/macosx/universal/TestUniversal.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/macosx/universal/TestUniversal.py?rev=113037&r1=113036&r2=113037&view=diff
==============================================================================
--- lldb/trunk/test/macosx/universal/TestUniversal.py (original)
+++ lldb/trunk/test/macosx/universal/TestUniversal.py Fri Sep  3 18:49:16 2010
@@ -9,9 +9,14 @@
 
     mydir = "macosx/universal"
 
+    @unittest2.skipUnless(sys.platform.startswith("darwin") and os.uname()[4]=='i386',
+                          "requires Darwin & i386")
     def test_process_launch_for_universal(self):
         """Test process launch of a universal binary."""
 
+        # Invoke the default build rule.
+        self.buildDefault()
+
         # Note that "testit" is a universal binary.
         exe = os.path.join(os.getcwd(), "testit")
 

Modified: lldb/trunk/test/plugins/darwin.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/plugins/darwin.py?rev=113037&r1=113036&r2=113037&view=diff
==============================================================================
--- lldb/trunk/test/plugins/darwin.py (original)
+++ lldb/trunk/test/plugins/darwin.py Fri Sep  3 18:49:16 2010
@@ -2,6 +2,12 @@
 
 #print "Hello, darwin plugin!"
 
+def buildDefault():
+    lldbtest.system(["/bin/sh", "-c", "make clean; make"])
+
+    # True signifies that we can handle building default.
+    return True
+
 def buildDsym():
     lldbtest.system(["/bin/sh", "-c", "make clean; make MAKE_DSYM=YES"])