[Lldb-commits] [lldb] r107357 - in /lldb/trunk/test: array_types/TestArrayTypes.py class_types/TestClassTypes.py help/TestHelp.py
clattner at apple.com
Wed Jun 30 18:34:43 PDT 2010
On Jun 30, 2010, at 5:40 PM, Daniel Dunbar wrote:
> On Wed, Jun 30, 2010 at 5:18 PM, Johnny Chen <johnny.chen at apple.com> wrote:
>> Author: johnny
>> Date: Wed Jun 30 19:18:39 2010
>> New Revision: 107357
>> URL: http://llvm.org/viewvc/llvm-project?rev=107357&view=rev
>> Added some delay (100 ms) after executing each 'command interpreter' command;
>> this seems to alleviate the intermittent failure observed while running the
>> whole test suite.
> I would strongly recommend not going down this road. There are two big
> problems with adding arbitrary timeouts:
> 1. They are never "exactly right", and it is always possible that a
> loaded machine or some other hickup will give sporadic test failures.
> This is a real bane for automated testing, as it makes it hard to
> generate reliable reports that people will pay attention to.
> 2. Because most of the time the timeouts aren't needed, they end up
> making the test suite a lot slower than it needs to be.
Also: 3. This is probably papering over a race condition or some other serious bug that will continue to manifest. It would be much better to track the real problem down and fix it.
More information about the lldb-commits