<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link="#0563C1" vlink="#954F72"><div class=WordSection1><p class=MsoNormal>Omitted +libcxx-dev list by accident w/reply.<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><div style='border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt'><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b>From:</b> Brian Cain <bcain@codeaurora.org> <br><b>Sent:</b> Monday, May 11, 2020 12:45 PM<br><b>To:</b> bcain@codeaurora.org; ldionne@apple.com<br><b>Subject:</b> RE: [libcxx-dev] new format and LIBCXX*_EXECUTOR, LIBCXX_TARGET_INFO<o:p></o:p></p></div></div><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Hmm – my mistake, the LIBCXX_TARGET_INFO does still get applied as I expect but the executor behavior still seems different. <o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Instead of LIBCXX_EXECUTOR, I tried setting “self.executor” in the constructor for the CustomTargetInfo and that was not considered either. I’ll just track this missing executor bit down – probably just needs to be added to the CxxStandardLibraryTest.<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>-Brian<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><div style='border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt'><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b>From:</b> libcxx-dev <<a href="mailto:libcxx-dev-bounces@lists.llvm.org">libcxx-dev-bounces@lists.llvm.org</a>> <b>On Behalf Of </b>Brian Cain via libcxx-dev<br><b>Sent:</b> Monday, May 11, 2020 12:31 PM<br><b>To:</b> <a href="mailto:libcxx-dev@lists.llvm.org">libcxx-dev@lists.llvm.org</a>; <a href="mailto:ldionne@apple.com">ldionne@apple.com</a><br><b>Subject:</b> [libcxx-dev] new format and LIBCXX*_EXECUTOR, LIBCXX_TARGET_INFO<o:p></o:p></p></div></div><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Louis,<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal style='text-indent:.5in'>When the switch to the new test format landed on our downstream repo, it seemed as if the LIBCXX_EXECUTOR and LIBCXX_TARGET_INFO cmake arguments were being ignored. I can see a couple of apply/reverts and some fixes to executor behavior, so I expect that in general the use case for executors is already considered. But maybe not being set via cmake? That said, our downstream system that takes upstream commits will consider applying them out-of-order, so I’m not certain I have all of the fixes yet. I’ll continue to dig deeper, but I just wanted to take a step back and try to understand if the new format is intended to work like this or if there’s another way.<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>The local config generated by cmake looks like this:<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal style='margin-left:.5in'>projects/libcxx/test/lit.site.cfg<o:p></o:p></p><p class=MsoNormal style='margin-left:.5in'>30:config.executor = "PrefixExecutor([\"/bin/bash\", \"/path/to/target/test/wrapper.sh\"],LocalExecutor())"<o:p></o:p></p><p class=MsoNormal style='margin-left:.5in'>projects/libcxx/test/lit.site.cfg<o:p></o:p></p><p class=MsoNormal style='margin-left:.5in'>25:config.target_info = "libcxx.quic.custom_target_info.CustomTargetInfo"<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>… and the comment still gets emitted:<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal style='text-indent:.5in'>llvm-lit: /local/mnt/workspace/mc/llvm-project/libcxx/utils/libcxx/test/config.py:193: note: Using executor: 'PrefixExecutor(["/bin/bash", "/path/to/target/test/wrapper.sh"],LocalExecutor())'<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>… but then I see<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal style='margin-left:.5in'>: 'EXECUTED AS'; /usr/bin/python /src/llvm-project/libcxx/utils/run.py --codesign_identity "" --dependencies /build/projects/libcxx/test/libcxx/algorithms/alg.modifying.operations/alg.random.shuffle/Output/random_shuffle.cxx1z.pass.cpp.tmp.exe --env LIBCXX_SRC_ROOT=/src/llvm-project/libcxx --execdir /build/projects/libcxx/test/libcxx/algorithms/alg.modifying.operations/alg.random.shuffle/Output/random_shuffle.cxx1z.pass.cpp.tmp.execdir -- /build/projects/libcxx/test/libcxx/algorithms/alg.modifying.operations/alg.random.shuffle/Output/random_shuffle.cxx1z.pass.cpp.tmp.exe<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>If it’s just an oversight, I can provide a fix once I figure it out. I just wanted to double check whether or not we want these cmake definitions to work in the future.<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>-Brian<o:p></o:p></p></div></div></div></body></html>