<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Mar 11, 2020, at 14:34, Eric Christopher <<a href="mailto:echristo@gmail.com" class="">echristo@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class=""><a class="gmail_plusreply" id="plusReplyChip-0" href="mailto:jgorbe@google.com" tabindex="-1">+Jorge Gorbe Moya</a> <a class="gmail_plusreply" id="plusReplyChip-1" href="mailto:saugustine@google.com" tabindex="-1">+saugustine@google.com</a> <br class=""></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Mar 11, 2020 at 11:31 AM Louis Dionne <<a href="mailto:ldionne@apple.com" class="">ldionne@apple.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;" class="">+EricWF<br class=""><div class=""><br class=""><blockquote type="cite" class=""><div class="">On Mar 11, 2020, at 14:07, Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank" class="">echristo@gmail.com</a>> wrote:</div><br class=""><div class=""><div dir="auto" class="">Agreed. Let's talk about any code sharing ahead of time though if you wouldn't mind :)</div></div></blockquote><div class=""><br class=""></div><div class="">There's a few candidates:</div><div class="">- CMake functions that could be used by both</div></div></div></blockquote><div class=""><br class=""></div><div class="">Anything build system related is great in my book.</div><div class=""> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;" class=""><div class=""><div class="">- the atomic_support.h header copy-pasted into libc++</div><div class=""><br class=""></div><div class="">I think EricWF has a laundry list of technical debt we've accumulated because of this.</div><div class=""><br class=""></div></div></div></blockquote><div class=""><br class=""></div><div class="">*nod*</div><div class=""> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;" class=""><div class=""><div class=""></div><div class="">Eric (echristo@), is opening a Phab review with those code sharing changes sufficient, or did you mean something additional by "talk about code sharing ahead of time"?</div><blockquote type="cite" class=""><div class=""><br class=""></div></blockquote></div></div></blockquote><div class="">A phab review sounds good to me, I was mostly concerned with sharing in libc++abi in such a way that it wasn't separately buildable if necessary, etc. Probably not really a worry, but just wanted to think about it. If something happens and it breaks some use cases terribly we can also just bring it up :)</div></div></div></div></blockquote><div><br class=""></div><div>If by "separately buildable" you mean building libc++abi.dylib (and its headers) as a standalone build product, then we will for sure retain that. I personally have use cases for that and I strongly suspect many others do, too.</div><div><br class=""></div><div>Louis</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_quote"><div class=""><br class=""></div><div class="">-eric</div><div class=""><br class=""></div><div class=""> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;" class=""><div class=""><blockquote type="cite" class=""><div class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Mar 11, 2020, 10:50 AM James Y Knight via libcxx-dev <<a href="mailto:libcxx-dev@lists.llvm.org" target="_blank" class="">libcxx-dev@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr" class="">+1. Any simplifications and cleanups of the buildsystem SGTM.<br class=""></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Mar 11, 2020 at 1:28 PM Louis Dionne via libcxx-dev <<a href="mailto:libcxx-dev@lists.llvm.org" rel="noreferrer" target="_blank" class="">libcxx-dev@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="">Hey folks,<div class=""><br class=""></div><div class="">Now that the monorepo is the standard, would everybody be fine with requiring both libc++ and libc++abi sources to be accessible in a monorepo-like layout when building either of them? In other words, in order to build either libc++ or libc++abi, we would require the following layout:</div><div class=""><br class=""></div><div class=""><font face="Monaco" class=""><span style="font-style:normal" class=""> <root>/libcxx</span></font></div><div class=""><font face="Monaco" class=""><span style="font-style:normal" class=""> <root>/libcxxabi</span></font></div><div class=""><br class=""></div><div class="">I suggest not requiring the rest of the monorepo, simply because it wouldn't be useful, and I know of at least one use case that would break.</div><div class=""><br class=""></div><div class="">The benefit of adopting this assumption is that all the search for libcxx and libcxxabi sources can be removed, simplifying the build quite a bit. Eventually, we can even start sharing stuff between the two sub-projects. If we go forward with this, I'll be happy to make the clean ups I mention.</div><div class=""><br class=""></div><div class="">Cheers,</div><div class="">Louis</div></div></blockquote></div></blockquote></div></div></blockquote></div><br class=""></div></blockquote></div></div>
</div></blockquote></div><br class=""></body></html>