<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Dec 1, 2019, at 11:59 PM, Marshall Clow <<a href="mailto:mclow.lists@gmail.com" class="">mclow.lists@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div dir="ltr" class="">On Fri, Nov 29, 2019 at 11:51 PM David Zarzycki <<a href="mailto:dave@znu.io" class="">dave@znu.io</a>> wrote:<br class=""></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;" class=""><div class=""><div class=""><blockquote type="cite" class=""><div class="">On Nov 29, 2019, at 11:30 PM, Marshall Clow <<a href="mailto:mclow.lists@gmail.com" target="_blank" class="">mclow.lists@gmail.com</a>> wrote:</div><br class=""><div class=""><div dir="ltr" class=""><div dir="ltr" class="">On Fri, Nov 29, 2019 at 3:50 AM David Zarzycki via libcxx-dev <<a href="mailto:libcxx-dev@lists.llvm.org" target="_blank" class="">libcxx-dev@lists.llvm.org</a>> wrote:<br class=""></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Do any of the bots test libcxx with top-of-tree clang? More than once I’ve suspected the answer is “no”. Most recently, the test suite has been broken for a few days now. I’ve worked around the problem by adding -Wno-deprecated-copy to the test suite config but somebody needs to decide if that’s the best long term solution.<br class=""></blockquote><div class=""><br class=""></div><div class="">My understanding is that (several of) the libcxx test bots get updated to the latest clang on a regular basis, but not on every run.</div><div class="">So they may lag behind ToT by a week or so at times.</div></div></div></div></blockquote></div><div class="">Okay.</div><div class=""><br class=""></div><div class="">Separably, why is important for the test suite to fail when new warnings are introduced? Is there a way to relax the test suite?</div></div></div></blockquote><div class=""><br class=""></div><div class="">I believe that it is the responsibility of the people implementing the new warnings to ensure that all of LLVM (and that includes clang, libc++, etc) builds cleanly with the new warning(s) enabled - and that this should happen *before* the warning is enabled.</div><div class=""><br class=""></div><div class="">This is what I have done when I have made changes to clang.</div></div></div></div></blockquote><br class=""></div><div>I think my question was misunderstood, so please let me rephrase: why is important that the test suite pass with all warnings (both present and future) turned into errors?</div><div><br class=""></div><div>At the very least, can we please add a CMake option to disable unqualified -Werror? (i.e. -Werror without the equal sign.)</div><div><br class=""></div><div>Dave</div><div><br class=""></div></body></html>