<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Jul 19, 2019, at 16:39, Duncan Exon Smith via libcxx-dev <<a href="mailto:libcxx-dev@lists.llvm.org" class="">libcxx-dev@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="content-type" content="text/html; charset=utf-8" class=""><div dir="auto" role="textbox" aria-label="Message Body" class=""><div dir="ltr" class="">You should be able to sniff in lit.local.config whether (a new enough) gdb is installed and mark the tests unsupported if not. Unsupported is better than xfail here. </div></div></div></blockquote><div><br class=""></div><div>This assumes that the tests are even using `lit`. I don’t know whether that’s the case. Let’s wait for the PR to be up!</div><div><br class=""></div><div>Louis</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="auto" role="textbox" aria-label="Message Body" class=""><div dir="ltr" class=""><br class=""><blockquote type="cite" class="">On Jul 19, 2019, at 20:09, Louis Dionne via libcxx-dev <<a href="mailto:libcxx-dev@lists.llvm.org" class="">libcxx-dev@lists.llvm.org</a>> wrote:<br class=""><br class=""></blockquote></div><blockquote type="cite" class=""><div dir="ltr" class=""><meta http-equiv="Content-Type" content="text/html; charset=utf-8" class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Jul 19, 2019, at 13:38, Sterling Augustine <<a href="mailto:saugustine@google.com" class="">saugustine@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">I'm working on this today. Question:<div class=""><br class=""></div><div class="">What directories would be best for the python package and the associated tests? They don't seem to fit well in any current directories.</div></div></div></blockquote><div class=""><br class=""></div><div class="">Under libcxx/test, we could add a new directory like libcxx/test/gdb. We need to keep this out of the directories normally considered by lit, but I think that’s the only hard requirement.</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class=""><br class=""></div><div class="">If gdb isn't installed on the machine, should they fail or not run? There are tradeoffs with both approaches.</div></div></div></blockquote><div class=""><br class=""></div><div class="">They should not run unless there’s a compelling reason to do otherwise. We don’t want to tie passing the libc++ test suite to having gdb installed!</div><div class=""><br class=""></div><div class="">Note that whatever approach we use, it would be nice if we could use the same approach for the lldb formatters once/if the LLDB folks decide to send them our way.</div><div class=""><br class=""></div><div class="">Louis</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class=""><br class=""></div><div class="">Getting them shipped to actual users is a different can of worms, but we can look at that when we actually have something to work with.</div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jul 18, 2019 at 9:23 AM Sterling Augustine <<a href="mailto:saugustine@google.com" class="">saugustine@google.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr" class="">Yes they will need gdb to run, and we will go through the full review process with all of it.</div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jul 18, 2019 at 9:08 AM Louis Dionne <<a href="mailto:ldionne@apple.com" target="_blank" class="">ldionne@apple.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="">I'm assuming the tests need GDB in order to run -- is that correct? I assume you'll put up a Phab review when you're ready?<div class=""><br class=""></div><div class="">Louis<br class=""><div class=""><br class=""><blockquote type="cite" class=""><div class="">On Jul 17, 2019, at 16:40, Sterling Augustine <<a href="mailto:saugustine@google.com" target="_blank" class="">saugustine@google.com</a>> wrote:</div><br class="gmail-m_7382432424048184403gmail-m_-5214308898581693393Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div dir="ltr" class="">On Wed, Jul 17, 2019 at 12:53 PM Louis Dionne <<a href="mailto:ldionne@apple.com" target="_blank" class="">ldionne@apple.com</a>> wrote:<br class=""></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="">What do the tests look like? Is that something that we can reasonably run as part of the libc++ test suite?</div></blockquote><div class=""><br class=""></div><div class="">Yes. I would upstream the tests them as part of upstreaming the printers. I'm working on this.</div></div></div>
</div></blockquote></div><br class=""></div></div></blockquote></div>
</blockquote></div>
</div></blockquote></div><br class=""><span class="">_______________________________________________</span><br class=""><span class="">libcxx-dev mailing list</span><br class=""><span class=""><a href="mailto:libcxx-dev@lists.llvm.org" class="">libcxx-dev@lists.llvm.org</a></span><br class=""><span class=""><a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-dev" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-dev</a></span><br class=""></div></blockquote></div>_______________________________________________<br class="">libcxx-dev mailing list<br class=""><a href="mailto:libcxx-dev@lists.llvm.org" class="">libcxx-dev@lists.llvm.org</a><br class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-dev<br class=""></div></blockquote></div><br class=""></body></html>