[libcxx-dev] [Release-testers] [8.0.0 Release] rc1 has been tagged

[Dimitry Andric via libcxx-dev]

On 24 Jan 2019, at 20:34, Michał Górny <mgorny at gentoo.org> wrote:
> 
> On Thu, 2019-01-24 at 19:58 +0100, Dimitry Andric via Release-testers
> wrote:
>> On 24 Jan 2019, at 01:49, Hans Wennborg via Release-testers <release-testers at lists.llvm.org> wrote:
>>> 
>>> 8.0.0-rc1 was just tagged (from the branch at r351980).
>>> 
>>> It took a little longer than planned, but it's looking good.
>>> 
>>> Please run the test script, share your results, and upload binaries.
>> 
>> Unfortunately I'm running into a problem with check-all, where it fails to link XRayTest-x86_64-Test:
>> 
>> [100%] Generating XRayTest-x86_64-Test
>> /home/dim/llvm/8.0.0/rc1/Phase3/Release/llvmCore-8.0.0-rc1.obj/./lib/libLLVMSupport.a(Signals.cpp.o): In function `llvm::sys::PrintStackTrace(llvm::raw_ostream&)':
>> Signals.cpp:(.text._ZN4llvm3sys15PrintStackTraceERNS_11raw_ostreamE+0x24): undefined reference to `backtrace'
>> Signals.cpp:(.text._ZN4llvm3sys15PrintStackTraceERNS_11raw_ostreamE+0x254): undefined reference to `llvm::itaniumDemangle(char const*, char*, unsigned long*, int*)'
>> clang-8: error: linker command failed with exit code 1 (use -v to see invocation)
>> gmake[3]: *** [projects/compiler-rt/lib/xray/tests/unit/CMakeFiles/TXRayTest-x86_64-Test.dir/build.make:73: projects/compiler-rt/lib/xray/tests/unit/XRayTest-x86_64-Test] Error 1
>> gmake[3]: Target 'projects/compiler-rt/lib/xray/tests/unit/CMakeFiles/TXRayTest-x86_64-Test.dir/build' not remade because of errors.
>> gmake[2]: *** [CMakeFiles/Makefile2:33513: projects/compiler-rt/lib/xray/tests/unit/CMakeFiles/TXRayTest-x86_64-Test.dir/all] Error 2
>> gmake[2]: Target 'CMakeFiles/check-all.dir/all' not remade because of errors.
>> gmake[1]: *** [CMakeFiles/Makefile2:737: CMakeFiles/check-all.dir/rule] Error 2
>> gmake[1]: Target 'check-all' not remade because of errors.
>> gmake: *** [Makefile:277: check-all] Error 2
>> [Release Phase3] check-all failed
>> 
>> It appears this is because -lexecinfo is not passed to the link command line, but I'm unsure why this only seems to affect the XRay test.  I'm investigating, but if anybody has a cluestick, please hit me. :-)
>> 
> 
> We've been having similar issue on NetBSD in the past.  Long story
> short, the code around there is not using CMake rules to build stuff but
> a custom compiler invocation, and therefore it does not inherit library
> dependencies from CMake.
> 
> Short-term solution is to figure out what's missing and add it, with
> appropriate conditionals.

Yes, I'm attempting again with this diff applied:

--- llvm.src/projects/compiler-rt/cmake/config-ix.cmake
+++ llvm.src/projects/compiler-rt/cmake/config-ix.cmake
@@ -118,6 +118,7 @@ check_library_exists(dl dlopen "" COMPIL
 check_library_exists(rt shm_open "" COMPILER_RT_HAS_LIBRT)
 check_library_exists(m pow "" COMPILER_RT_HAS_LIBM)
 check_library_exists(pthread pthread_create "" COMPILER_RT_HAS_LIBPTHREAD)
+check_library_exists(execinfo backtrace "" COMPILER_RT_HAS_LIBEXECINFO)

 # Look for terminfo library, used in unittests that depend on LLVMSupport.
 if(LLVM_ENABLE_TERMINFO)
--- llvm.src/projects/compiler-rt/lib/xray/tests/CMakeLists.txt
+++ llvm.src/projects/compiler-rt/lib/xray/tests/CMakeLists.txt
@@ -71,13 +71,14 @@ if (NOT APPLE)
     endforeach()

     # We also add the actual libraries to link as dependencies.
-    list(APPEND XRAY_UNITTEST_LINK_FLAGS -lLLVMXRay -lLLVMSupport -lLLVMTestingSupport)
+    list(APPEND XRAY_UNITTEST_LINK_FLAGS -lLLVMXRay -lLLVMSupport -lLLVMDemangle -lLLVMTestingSupport)
   endif()

   append_list_if(COMPILER_RT_HAS_LIBM -lm XRAY_UNITTEST_LINK_FLAGS)
   append_list_if(COMPILER_RT_HAS_LIBRT -lrt XRAY_UNITTEST_LINK_FLAGS)
   append_list_if(COMPILER_RT_HAS_LIBDL -ldl XRAY_UNITTEST_LINK_FLAGS)
   append_list_if(COMPILER_RT_HAS_LIBPTHREAD -pthread XRAY_UNITTEST_LINK_FLAGS)
+  append_list_if(COMPILER_RT_HAS_LIBEXECINFO -lexecinfo XRAY_UNITTEST_LINK_FLAGS)
 endif()

 macro(add_xray_unittest testname)


Now the next problem is a Asan:DEADLYSIGNAL which keeps on repeating endlessly. :-)

-Dimitry

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 223 bytes
Desc: Message signed with OpenPGP
URL: <http://lists.llvm.org/pipermail/libcxx-dev/attachments/20190124/e056be52/attachment.sig>