<div dir="ltr">Post-commit review: shout if you'd prefer that I remove this code for libc++ as well.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Oct 19, 2020 at 5:14 PM Casey Carter via libcxx-commits <<a href="mailto:libcxx-commits@lists.llvm.org">libcxx-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Casey Carter<br>
Date: 2020-10-19T17:14:01-07:00<br>
New Revision: 877766573b21a72b04371b8790c0828dc7176f5d<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/877766573b21a72b04371b8790c0828dc7176f5d" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/877766573b21a72b04371b8790c0828dc7176f5d</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/877766573b21a72b04371b8790c0828dc7176f5d.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/877766573b21a72b04371b8790c0828dc7176f5d.diff</a><br>
<br>
LOG: [libc++][test] Don't violate precondition [atomics.flag]/6<br>
<br>
... which forbids passing `memory_order_release` or `memory_order_acq_rel` to either overload of `atomic_flag_test_explicit`.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    libcxx/test/std/atomics/atomics.flag/atomic_flag_test_explicit.pass.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/libcxx/test/std/atomics/atomics.flag/atomic_flag_test_explicit.pass.cpp b/libcxx/test/std/atomics/atomics.flag/atomic_flag_test_explicit.pass.cpp<br>
index 45ac737b5984..af3665f13300 100644<br>
--- a/libcxx/test/std/atomics/atomics.flag/atomic_flag_test_explicit.pass.cpp<br>
+++ b/libcxx/test/std/atomics/atomics.flag/atomic_flag_test_explicit.pass.cpp<br>
@@ -43,6 +43,7 @@ int main(int, char**)<br>
         assert(f.test_and_set() == 0);<br>
         assert(atomic_flag_test_explicit(&f, std::memory_order_acquire) == 1);<br>
     }<br>
+#ifdef _LIBCPP_VERSION // Don't violate precondition [atomics.flag]/6<br>
     {<br>
         std::atomic_flag f;<br>
         f.clear();<br>
@@ -57,6 +58,7 @@ int main(int, char**)<br>
         assert(f.test_and_set() == 0);<br>
         assert(atomic_flag_test_explicit(&f, std::memory_order_acq_rel) == 1);<br>
     }<br>
+#endif // _LIBCPP_VERSION<br>
     {<br>
         std::atomic_flag f;<br>
         f.clear();<br>
@@ -85,6 +87,7 @@ int main(int, char**)<br>
         assert(f.test_and_set() == 0);<br>
         assert(atomic_flag_test_explicit(&f, std::memory_order_acquire) == 1);<br>
     }<br>
+#ifdef _LIBCPP_VERSION // Don't violate precondition [atomics.flag]/6<br>
     {<br>
         volatile std::atomic_flag f;<br>
         f.clear();<br>
@@ -99,6 +102,7 @@ int main(int, char**)<br>
         assert(f.test_and_set() == 0);<br>
         assert(atomic_flag_test_explicit(&f, std::memory_order_acq_rel) == 1);<br>
     }<br>
+#endif // _LIBCPP_VERSION<br>
     {<br>
         volatile std::atomic_flag f;<br>
         f.clear();<br>
<br>
<br>
<br>
_______________________________________________<br>
libcxx-commits mailing list<br>
<a href="mailto:libcxx-commits@lists.llvm.org" target="_blank">libcxx-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-commits</a><br>
</blockquote></div>